After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776798 - typo fixes
typo fixes
Status: RESOLVED FIXED
Product: libcroco
Classification: Core
Component: General
unspecified
Other All
: Normal minor
: ---
Assigned To: libcroco maintainers
libcroco maintainers
Depends on:
Blocks:
 
 
Reported: 2017-01-03 09:21 UTC by Mattia Rizzolo
Modified: 2017-03-26 11:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
s/Instantiation/instantiation/ (3.32 KB, patch)
2017-01-03 09:21 UTC, Mattia Rizzolo 		needs-work Details | Review
s/unknow/unknown/ (5.32 KB, patch)
2017-01-03 09:22 UTC, Mattia Rizzolo 		needs-work Details | Review
s/occured/occurred/ (3.26 KB, patch)
2017-01-03 09:22 UTC, Mattia Rizzolo 		committed Details | Review
s/Instanciation/instantiation/ (3.32 KB, patch)
2017-03-10 12:08 UTC, Mattia Rizzolo 		committed Details | Review
s/unknow/unknown/ (2.31 KB, patch)
2017-03-10 12:11 UTC, Mattia Rizzolo 		committed Details | Review

Description Mattia Rizzolo 2017-01-03 09:21:43 UTC 
Created attachment 342749 [details] [review]
s/Instantiation/instantiation/

Attached 3 patches fixing typos on 3 different words.

Origin: https://bugs.launchpad.net/inkscape/+bug/1653371
Comment 1 Mattia Rizzolo 2017-01-03 09:22:20 UTC 
Created attachment 342750 [details] [review]
s/unknow/unknown/
Comment 2 Mattia Rizzolo 2017-01-03 09:22:48 UTC 
Created attachment 342751 [details] [review]
s/occured/occurred/
Comment 3 Ignacio Casal Quinteiro (nacho) 2017-03-10 09:56:25 UTC 
Review of attachment 342749 [details] [review]:

Looks good.
Comment 4 Ignacio Casal Quinteiro (nacho) 2017-03-10 09:57:22 UTC 
Review of attachment 342750 [details] [review]:

It seems you mixed the patch with the previous one. Otherwise feel free to push the unknown only patch
Comment 5 Ignacio Casal Quinteiro (nacho) 2017-03-10 09:57:48 UTC 
Review of attachment 342751 [details] [review]:

Looks good.
Comment 6 Mattia Rizzolo 2017-03-10 12:07:52 UTC 
Comment on attachment 342749 [details] [review]
s/Instantiation/instantiation/

ahah, the commit message is wrong here.
Comment 7 Mattia Rizzolo 2017-03-10 12:08:46 UTC 
Created attachment 347620 [details] [review]
s/Instanciation/instantiation/

this is with the right commit message.
Comment 8 Mattia Rizzolo 2017-03-10 12:10:20 UTC 
Comment on attachment 342750 [details] [review]
s/unknow/unknown/

sigh, I must have fucked up with git, actually this was reverting the previous patch doing s/Instanciation/instantiation/ ...
Comment 9 Mattia Rizzolo 2017-03-10 12:11:07 UTC 
Created attachment 347621 [details] [review]
s/unknow/unknown/

Thanks for reviewing.  It should be correct now.
Comment 10 Ignacio Casal Quinteiro (nacho) 2017-03-26 11:19:52 UTC 
Thanks