GNOME Bugzilla – Bug 776796
Desktop file has a "@VERSION@" in it
Last modified: 2017-01-05 13:24:29 UTC
I imagine that (as in many other modules) the desktop file was once upon a time generated by a .desktop.in.in one. If I understood correctly, the goal of this double transformation was first to replace the ‘@VERSION@’ by the version number, and of course second for translating. Now, the ‘X-GNOME-Bugzilla-Version=@VERSION@’ thing finishes directly in the desktop files (*four* desktop files, I think all linked to Nautilus: mount-archive.desktop, nautilus-autorun-software.desktop, nautilus-classic.desktop, org.gnome.Nautilus.desktop). I think you should either go back to .in.in files, or I think (that’s a custom solution, so I might have done some errors in it) you could either use the Makefile for doing that like in dconf-editor[1]. Or you might remove the ‘X-GNOME-Bugzilla’ things. [1] https://git.gnome.org/browse/dconf-editor/commit/?id=74f8e199a1f601cdff2d5788c2ab345f0f7031bb
Created attachment 342775 [details] [review] general: fix data file variable substitution Some data files use AC_SUBST’ed variables, but they are not substituted, because of removed entries from AC_CONFIG_FILES. One of the files is no longer used, so it was removed.
Created attachment 342779 [details] [review] general: fix data file variable substitution Some data files use AC_SUBST’ed variables, but they are not substituted, because of removed entries from AC_CONFIG_FILES. One of the files is no longer used, so it was removed.
Review of attachment 342779 [details] [review]: oh I didn't realized that. I wonder, do we really need this at all? I don't see any place where this is convenient... I'm pondering it would be better to just remove it.
(In reply to Carlos Soriano from comment #3) > Review of attachment 342779 [details] [review] [review]: > > oh I didn't realized that. I wonder, do we really need this at all? I don't > see any place where this is convenient... I'm pondering it would be better > to just remove it. Bug Buddy parses all that schmutz, but I have no idea if anyone uses it.
(In reply to Ernestas Kulik from comment #4) > (In reply to Carlos Soriano from comment #3) > > Review of attachment 342779 [details] [review] [review] [review]: > > > > oh I didn't realized that. I wonder, do we really need this at all? I don't > > see any place where this is convenient... I'm pondering it would be better > > to just remove it. > > Bug Buddy parses all that schmutz, but I have no idea if anyone uses it. Oh I see, this looks very outdated, let's remove it.
Created attachment 342861 [details] [review] general: remove search provider service It was to be removed in 39b4fc320b2a4ef6cfd36f7e2f74cc2cfcf60e9d.
Created attachment 342862 [details] [review] general: remove Bug Buddy metadata from desktop files Bug Buddy is no longer actively maintained and probably even less actively used. ABRT and Apport seem to not parse these things as well.
Created attachment 342863 [details] [review] general: use Autoconf to perform substitution Variables in service files are substituted using sed, which takes more space than a couple of lines in configure.ac.
Created attachment 342864 [details] [review] data/Makefile.am: fix up indentation
Review of attachment 342861 [details] [review]: +1
Review of attachment 342862 [details] [review]: +1
Review of attachment 342863 [details] [review]: I wonder if we should keep these things in case we switch to a different build system, but oh well we can always recheck the code we used in the past :)
Review of attachment 342864 [details] [review]: +1
Attachment 342861 [details] pushed as 04173f0 - general: remove search provider service Attachment 342862 [details] pushed as 3868b4c - general: remove Bug Buddy metadata from desktop files Attachment 342863 [details] pushed as 48cd707 - general: use Autoconf to perform substitution Attachment 342864 [details] pushed as db8e84d - data/Makefile.am: fix up indentation
(In reply to Carlos Soriano from comment #12) > I wonder if we should keep these things in case we switch to a different > build system, but oh well we can always recheck the code we used in the past > :) Not only that, it’s required, because running the file through Autoconf only substitutes the variable, but does not expand it. “@bindir@” -> “${exec_prefix}” instead of the actual path. I have reverted the commit.
(In reply to Ernestas Kulik from comment #15) > (In reply to Carlos Soriano from comment #12) > > I wonder if we should keep these things in case we switch to a different > > build system, but oh well we can always recheck the code we used in the past > > :) > > Not only that, it’s required, because running the file through Autoconf only > substitutes the variable, but does not expand it. “@bindir@” -> > “${exec_prefix}” instead of the actual path. > > I have reverted the commit. Oh I see, thanks for keeping an eye to your commits!