After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776790 - Fixed memory leak in gst module in usage of gst_pad_template_new() API
Fixed memory leak in gst module in usage of gst_pad_template_new() API
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.9.1
Other Linux
: Normal normal
: 1.11.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-01-03 05:28 UTC by Garima
Modified: 2017-01-03 10:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fixed memory leak in gst module in usage of gst_pad_template_new() API (1.42 KB, patch)
2017-01-03 05:28 UTC, Garima 		committed Details | Review

Description Garima 2017-01-03 05:28:19 UTC 
Created attachment 342743 [details] [review]
Fixed memory leak in gst module in usage of gst_pad_template_new() API

The last argument to gst_pad_template_new() is not freed.

Added gst_caps_unref() to free the allocated memory.

Please review the attached patch.
Comment 1 Tim-Philipp Müller 2017-01-03 10:04:31 UTC 
Thanks, squashed this with the other patch:

commit 81b0a14d692bb679c5688ef597e5aab6f0ce7730
Author: Garima Gaur <garima.g@samsung.com>
Date:   Tue Jan 3 09:02:36 2017 +0530

    Fix some caps leaks in pad template creation code
    
    gst_pad_template_new() does not take ownership of
    the caps passed to it, so we need to unref the caps.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=776790
    https://bugzilla.gnome.org/show_bug.cgi?id=776787