After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776680 - 'Select All' doesn't have an action in Artists tab
'Select All' doesn't have an action in Artists tab
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.23.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2017-01-01 14:09 UTC by Mohammed Sadiq
Modified: 2017-02-13 21:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix selection on artists view (1.11 KB, patch)
2017-01-05 08:33 UTC, Alberto Fanjul 		committed Details | Review

Description Mohammed Sadiq 2017-01-01 14:09:33 UTC 
How to reproduce:

1. Go to Artists tab
2. Initiate selection mode via right click (or clicking the tick button)
3. From the selection menu in HeaderBar, select 'Select All'

Result:
Nothing happens

Expected Result:
Every item should be selected
Comment 1 Alberto Fanjul 2017-01-05 08:33:01 UTC 
Created attachment 342927 [details] [review]
Fix selection on artists view

Select all/none is implemented on baseview but is based on model from SongsView (where it works correctly) This patch overrides implementation for ArtistsView. Maybe a best solution would be to extract the decisor to mark a row (baseview.py:275)

     if self.model[_iter][5]:

to be override from any view extending baseview. But I prefer to upload a simple patch and discuss a further refactor for codebase
Comment 2 Marinus Schraal 2017-01-16 11:35:41 UTC 
This may be some fallout from the albumwidget rewrite.
Comment 3 Alberto Fanjul 2017-02-02 19:46:29 UTC 
In the end this will be accepted or rejected?
Comment 4 Marinus Schraal 2017-02-13 21:19:45 UTC 
This is a real problem now and the fix looks alright. Thanks for the 
patch.

Did rewrite the commit msg somewhat.