After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776653 - PATCH: ProcInfo reform
PATCH: ProcInfo reform
Status: RESOLVED FIXED
Product: system-monitor
Classification: Core
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: System-monitor maintainers
System-monitor maintainers
Depends on:
Blocks:
 
 
Reported: 2016-12-31 11:13 UTC by Artem Vorotnikov
Modified: 2017-05-22 16:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-Use-ProcInfo-all-directly.patch (5.54 KB, patch)
2016-12-31 11:13 UTC, Artem Vorotnikov 		committed Details | Review
0002-ProcInfos-owned-by-ProcInfo-all-ProcInfo-find-return.patch (9.15 KB, patch)
2016-12-31 11:14 UTC, Artem Vorotnikov 		committed Details | Review
0003-Deleted-ProcInfo-s-copy-and-copy-assignment-construc.patch (979 bytes, patch)
2016-12-31 11:15 UTC, Artem Vorotnikov 		committed Details | Review
0004-Moved-process-list-into-separate-class-now-owned-by-.patch (11.60 KB, patch)
2016-12-31 11:15 UTC, Artem Vorotnikov 		committed Details | Review
0005-ProcInfo-now-has-std-string-fields.patch (15.01 KB, patch)
2016-12-31 11:15 UTC, Artem Vorotnikov 		committed Details | Review

Description Artem Vorotnikov 2016-12-31 11:13:38 UTC 
This patch set contains refactoring of ProcInfo class:
- Storage of ProcInfo is moved to a separate ProcTable (owned by GsmApplication) out of ProcInfo itself. It makes the code aligned with single responsibility principle and eases future refactoring. ProcTable's interface is modelled after std::map.
- ProcInfo now uses std::string for its information fields. Less memory management, more safety.
- Copy and copy assignment constructors are explicitly deleted (as they should be with C++11)
Comment 1 Artem Vorotnikov 2016-12-31 11:13:59 UTC 
Created attachment 342659 [details] [review]
0001-Use-ProcInfo-all-directly.patch
Comment 2 Artem Vorotnikov 2016-12-31 11:14:42 UTC 
Created attachment 342660 [details] [review]
0002-ProcInfos-owned-by-ProcInfo-all-ProcInfo-find-return.patch
Comment 3 Artem Vorotnikov 2016-12-31 11:15:06 UTC 
Created attachment 342661 [details] [review]
0003-Deleted-ProcInfo-s-copy-and-copy-assignment-construc.patch
Comment 4 Artem Vorotnikov 2016-12-31 11:15:26 UTC 
Created attachment 342662 [details] [review]
0004-Moved-process-list-into-separate-class-now-owned-by-.patch
Comment 5 Artem Vorotnikov 2016-12-31 11:15:49 UTC 
Created attachment 342663 [details] [review]
0005-ProcInfo-now-has-std-string-fields.patch
Comment 6 Artem Vorotnikov 2016-12-31 11:17:58 UTC 
NOTE: while each patch should be standalone (if applied in original order), I have only extensively tested the full patch set. Feel free to squash the set if necessary.
Comment 7 Robert Roth 2017-05-22 16:35:49 UTC 
Thanks, this seems to work, let's land this early (well, not very early, but still)
to have some more testing and iron out issues (if any).