After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776649 - gtk4: Add Gst (GL) Gtk4 plugin
gtk4: Add Gst (GL) Gtk4 plugin
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-12-31 08:37 UTC by Yannick Inizan
Modified: 2018-11-03 15:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] Add Gst (GL) Gtk4 plugin (93.47 KB, patch)
2016-12-31 08:37 UTC, Yannick Inizan 		reviewed Details | Review

Description Yannick Inizan 2016-12-31 08:37:14 UTC 
Created attachment 342658 [details] [review]
[PATCH] Add Gst (GL) Gtk4 plugin

Since latest version of Gtk 4 works correctly, we can build a plugin with this version.
Comment 1 Tim-Philipp Müller 2016-12-31 09:26:34 UTC 
Hrm, I don't know if we want to just duplicate the code, then we'd have to maintain two copies of that.

I think baedert was looking into this too.
Comment 2 Sebastian Dröge (slomo) 2016-12-31 19:41:59 UTC 
There should definitely a better solution than copying it all. That's not good :) But thanks for the patch! Should also check with baedert's status
Comment 3 Timm Bäder 2017-01-01 00:37:54 UTC 
My status was that it was working but as far as I can see the patch attached here is a lot better, apart from the ::measure implementation which is doing basically the same thing for the horizontal/vertical cases and the indentation for the function header is wrong I think. I could link to my patch but it basically just copied the code of the current gtk3 version and changed the name to gtk4 (and even removed the GL part...).

I'm not sure how you want to work around the code duplication for the gtk3/4 widgets, I do know that Company has plans for removing the ::draw vfunc/signal entirely so the differences between the two could be rather large.
Comment 4 GStreamer system administrator 2018-11-03 15:15:38 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/338.