After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776616 - Mark messages as translatable
Mark messages as translatable
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2016-12-30 14:53 UTC by Baurzhan M
Modified: 2017-01-06 15:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
monitor: Mark error strings as translatable (6.88 KB, patch)
2017-01-02 11:47 UTC, Ondrej Holy
committed Details | Review

Description Baurzhan M 2016-12-30 14:53:00 UTC
Hi, while trying to unmount a busy usb disk I noticed that Nautilus shows the unable the eject message, with detailed error message stating "An operation is already pending" It turns out, in gvfs project git tree, it can be seen several times in file:

[user@host gvfs]$ grep -n 'An operation is already pending' -R .
./monitor/proxy/gvfsproxyvolumemonitordaemon.c:1045:                                                  "An operation is already pending");
./monitor/proxy/gvfsproxyvolumemonitordaemon.c:1224:                                                  "An operation is already pending");
./monitor/proxy/gvfsproxyvolumemonitordaemon.c:1331:                                                  "An operation is already pending");
./monitor/proxy/gvfsproxyvolumemonitordaemon.c:1438:                                                  "An operation is already pending");
./monitor/proxy/gvfsproxyvolumemonitordaemon.c:1545:                                                  "An operation is already pending");
./monitor/proxy/gvfsproxyvolumemonitordaemon.c:1648:                                                  "An operation is already pending");

Could you please mark these message for translation?
Thanks,
Comment 1 Ondrej Holy 2017-01-02 11:46:40 UTC
Thanks for your report.

Sure, I will prepare fix.
Comment 2 Ondrej Holy 2017-01-02 11:47:06 UTC
Created attachment 342710 [details] [review]
monitor: Mark error strings as translatable

Error strings in gvfsproxyvolumemonitordaemon.c are not marked as
translatable and thus it might be shown untranslated in UI, mark them.
Comment 3 Ondrej Holy 2017-01-06 15:37:26 UTC
Attachment 342710 [details] pushed as 275450e - monitor: Mark error strings as translatable