After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776587 - Build error opens to wrong file
Build error opens to wrong file
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-12-29 18:07 UTC by Michael Catanzaro
Modified: 2017-01-01 00:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot of bug (155.20 KB, image/png)
2016-12-29 18:07 UTC, Michael Catanzaro
  Details
gcc: allow path separators when parsing diagnostic filename (1.33 KB, patch)
2017-01-01 00:15 UTC, Christian Hergert
committed Details | Review

Description Michael Catanzaro 2016-12-29 18:07:04 UTC
Created attachment 342587 [details]
screenshot of bug

I have a build error in lib/ephy-hosts-manager.h. Whoops!

When I click on the error in Builder's sidebar, it opens the nonexistent file lib/widgets/ephy-hosts-manager.h. Huh?
Comment 1 Christian Hergert 2016-12-31 09:50:19 UTC
It looks like we need some regex tweaks. It seems to be happening as follows:

1: ephy-hosts-manager.h
2: /home/christian/Projects/epiphany/lib/widgets
3: lib/widgets/ephy-hosts-manager.h
4: /home/christian/Projects/epiphany/lib/widgets/ephy-hosts-manager.h

[1] Filename extracted from GCC error message
[2] Current directory from "Entering directory" via autotools
[3] Join [2] and [3]
[4] Prefix working directory to [3]
Comment 2 Christian Hergert 2017-01-01 00:15:38 UTC
Created attachment 342676 [details] [review]
gcc: allow path separators when parsing diagnostic filename

Previously, we were only getting the basename portion of the filename.
We need the relative path (so therefore path separators) so we can
resolve include files outside the current working directory.
Comment 3 Christian Hergert 2017-01-01 00:16:15 UTC
Thanks for reporting!

Attachment 342676 [details] pushed as 41d5da8 - gcc: allow path separators when parsing diagnostic filename