GNOME Bugzilla – Bug 776578
gl: Allow build even if no window system is enabled
Last modified: 2018-11-03 11:53:10 UTC
The gst-gl plugins and libraries should be allowed to build even if no window system is enabled. On platforms that do not provide a standard GL window system, this is useful for applications using gst-gl with their own sink, like WebKit with GSTREAMER_GL enabled. When no window system is supported, glimagesink will use a dummy window (see gst_gl_window_new).
Created attachment 342572 [details] [review] [PATCH] gl: Allow build even if no window system is enabled
Unfortunately, this is not rally possible with OpenGL as you always need a winsys of some description to be able to connect to the OpenGL server. What platform is this on? What GL platform (EGL, GLX, WGL, etc)? OS?
This is on a set-top box running Linux and proprietary OpenGL drivers, and no wayland-egl support. It is using EGL with a custom platform. This patch is mostly for the use-case where the EGL platform integration is done in the user application, WebKit in my case. See GL context creation: https://github.com/Metrological/WebKitForWayland/blob/32f1d053dc662c2ba300bf7f23349ac14451a7eb/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp#L466 And GL context sharing: https://github.com/Metrological/WebKitForWayland/blob/32f1d053dc662c2ba300bf7f23349ac14451a7eb/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp#L328 Though, you are right, my comment about glimagesink was incorrect, EGL context creation/init will likely fail when no winsys is available. Thanks for your feedback
Review of attachment 342572 [details] [review]: Just one comment. ::: configure.ac @@ -1278,3 @@ fi -if test "x$GL_APIS" = "x" -o "x$GL_PLATFORMS" = "x" -o "x$GL_WINDOWS" = "x"; then This would be better if GL_WINDOWS was never empty by prefilling it with "dummy" so the configure output is still correct.
Comment on attachment 342572 [details] [review] [PATCH] gl: Allow build even if no window system is enabled This also needs to update the meson build definitions for this change.
Olivier Blin, do you plan on updating these patches (against git master please, as gl is now in -base) or shall we close this?
I'll get a look at the Meson support, thanks for your patience.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/322.