GNOME Bugzilla – Bug 776544
Support Vulkan context creation on Windows
Last modified: 2016-12-29 10:11:40 UTC
Hi, As there is an experimental Vulkan renderer that is in the works for GSK, it might be worth it to add support to enable Vulkan surface/context creation on Windows, so that we can test it further on different platforms that Vulkan is supported on. I will attach patches to enable such features. With blessings, thank you!
Created attachment 342535 [details] [review] GDK/Win32: Support Vulkan Context creation Hi, This adds the code for GDK/Win32 to support creating Vulkan contexts/surfaces on Windows. I will update the Visual Studio build files once this lands in master. With blessings, thank you!
Review of attachment 342535 [details] [review]: Fix the minor alignment problems and feel free to push it ::: gdk/win32/gdkvulkancontext-win32.c @@ +37,3 @@ +static VkResult +gdk_win32_vulkan_context_create_surface (GdkVulkanContext *context, + VkSurfaceKHR *surface) align properly here ::: gdk/win32/gdkvulkancontext-win32.h @@ +35,3 @@ +#define GDK_TYPE_WIN32_VULKAN_CONTEXT (gdk_win32_vulkan_context_get_type ()) +#define GDK_WIN32_VULKAN_CONTEXT(obj) (G_TYPE_CHECK_INSTANCE_CAST ((obj), GDK_TYPE_WIN32_VULKAN_CONTEXT, GdkWin32VulkanContext)) +#define GDK_IS_WIN32_VULKAN_CONTEXT(obj) (G_TYPE_CHECK_INSTANCE_TYPE ((obj), GDK_TYPE_WIN32_VULKAN_CONTEXT)) align @@ +37,3 @@ +#define GDK_IS_WIN32_VULKAN_CONTEXT(obj) (G_TYPE_CHECK_INSTANCE_TYPE ((obj), GDK_TYPE_WIN32_VULKAN_CONTEXT)) +#define GDK_WIN32_VULKAN_CONTEXT_CLASS(klass) (G_TYPE_CHECK_CLASS_CAST ((klass), GDK_TYPE_WIN32_VULKAN_CONTEXT, GdkWin32VulkanContextClass)) +#define GDK_IS_WIN32_VULKAN_CONTEXT_CLASS(klass) (G_TYPE_CHECK_CLASS_TYPE ((klass), GDK_TYPE_WIN32_VULKAN_CONTEXT)) align
Review of attachment 342535 [details] [review]: Hi Nacho, Thanks! I pushed the patch with the formatting fixed, as c4244ea. With blessings, thank you!