After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776520 - [2.50] Remove TODOs about ABI break, made before branch to 2.51
[2.50] Remove TODOs about ABI break, made before branch to 2.51
Status: RESOLVED NOTABUG
Product: glibmm
Classification: Bindings
Component: general
2.50.x
Other All
: Low minor
: ---
Assigned To: gtkmm-forge
gtkmm-forge
Depends on:
Blocks:
 
 
Reported: 2016-12-27 13:24 UTC by Daniel Boles
Modified: 2017-01-12 11:30 UTC
See Also:
GNOME target: ---
GNOME version: 3.21/3.22


Attachments
[PATCH] Remove TODOs on ABI break, adding VFUNCs, etc. (24.88 KB, patch)
2016-12-27 13:30 UTC, Daniel Boles
none Details | Review

Description Daniel Boles 2016-12-27 13:24:45 UTC
moving from https://bugzilla.gnome.org/show_bug.cgi?id=774444#c22
Comment 1 Daniel Boles 2016-12-27 13:30:08 UTC
Created attachment 342497 [details] [review]
[PATCH] Remove TODOs on ABI break, adding VFUNCs, etc.

I hope this covers them all (and none it shouldn't)
Comment 2 Kjell Ahlstedt 2016-12-27 15:42:32 UTC
I think this is something that usually is not done after branching for an
ABI/API break. I don't know if we should bother. I let Murray decide.
Comment 3 Murray Cumming 2017-01-12 11:18:48 UTC
Indeed, I would prefer not to remove these TODOS from glibmm-2.4. They are still useful as a warning that making the change would break ABI.
Comment 4 Daniel Boles 2017-01-12 11:30:23 UTC
Hmm, that's quite a good point, and ensuring no breaking changes is a better reason than just tidying up a little bit. So, closing. Thanks for the reply!