After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776459 - event beginning date automatically gets decremented/incremented until it reaches January/December
event beginning date automatically gets decremented/incremented until it reac...
Status: RESOLVED FIXED
Product: gnome-calendar
Classification: Applications
Component: User Interface
3.22.x
Other Linux
: Normal blocker
: 3.26
Assigned To: GNOME Calendar maintainers
GNOME Calendar maintainers
Depends on:
Blocks:
 
 
Reported: 2016-12-24 01:45 UTC by Mohammed Sadiq
Modified: 2017-02-27 11:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
multi-choice: Fix endless timeout (1.39 KB, patch)
2017-02-23 16:04 UTC, Isaque Galdino
committed Details | Review

Description Mohammed Sadiq 2016-12-24 01:45:10 UTC
In some cases event start date get decremented automatically (without user interaction) until it reaches January 1st (or December in other cases).

How to reproduce:

1. Create some event (Should not be in the month of January)
2. Edit the event, and in detailed edit dialog select beginning month to January by clicking the back button in calendar widget (any year)
3. Now cancel the edit.
4. Now create another event (or open any created event) -> Edit (to open detailed event entry dialog), You can see that the month is Changed until the event begin date becomes January.

(This can also reproduced for December and event end date). As this is very common, I'm marking this as blocker.

fixing bug 776368 should also fix this.

Thanks.
Comment 1 Audrey Toskin 2016-12-30 22:53:30 UTC
I've run into this issue as well. It's pretty bizarre, and frustrating -- sometimes I can't enter the actual date of the event I'm trying to edit, because every time I open the date picker widget, or every time I try to manually type in a date, it keeps counting backwards to January 1st again.

I'm having a hard time reliably duplicating the bug; it just seems to happen randomly. Restarting the application temporarily resolves the problem, but that's not a great workaround if you're trying to enter a few events and todos at once while you can remember them.
Comment 2 Isaque Galdino 2017-02-23 16:04:01 UTC
Created attachment 346583 [details] [review]
multi-choice: Fix endless timeout

There are two mapped events for each back/forward buttons in this
widget: button-press and button-release.

When you reach the limits like January and December, button-release is
lost, and you don't get it anymore. That caused button_timeout function
to not be disable anymore, so it's kept in loop forever.

This code fix checks in button_timeout function if any of the back/
forward buttons are still mapped. If not, it prevents from calling
button_timout, stopping the loop.
Comment 3 Georges Basile Stavracas Neto 2017-02-23 17:35:59 UTC
Review of attachment 346583 [details] [review]:

LGTM
Comment 4 Georges Basile Stavracas Neto 2017-02-27 11:47:31 UTC
Attachment 346583 [details] pushed as 0bf0c9e - multi-choice: Fix endless timeout