After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776391 - Disable WebKit developer mode by default
Disable WebKit developer mode by default
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
3.22.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2016-12-22 13:12 UTC by Christian Stadelmann
Modified: 2017-01-18 10:48 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Christian Stadelmann 2016-12-22 13:12:47 UTC
Steps to reproduce:
1. open evolution, mail component
2. open any HTML email
3. press Ctrl+Shift+I to open the inspector
4. select a different message
5. press "X" button on the inspector

What should happen:
Close inspector

What happens:
Nothing. Inspector doesn't close. Nor does it detach. It works fine otherwise.

Software versions:
evolution-3.22.3-1.fc25.x86_64
gtk3-3.22.5-1.fc25.x86_64
glib2-2.50.2-1.fc25.x86_64
webkitgtk4-2.14.2-1.fc25.x86_64
Comment 1 Milan Crha 2017-01-03 12:59:00 UTC
Thanks for a bug report. It sounds like an issue in the webkitgtk4 itself, though I didn't check the code of the evolution. The inspector is also not meant to be used by the evolution users, it's meant for a debugging purposes only, thus I would simply WontFix-ing this due to it.
Comment 2 Christian Stadelmann 2017-01-03 13:02:38 UTC
I didn't mean to use the inspector, I opened it by accident. It would be nice if it either didn't open or could be closed.

How about disabling it? Is that possible? At least for non-debug builds?
Comment 3 Milan Crha 2017-01-03 18:21:32 UTC
Right. It seems to be a side-effect of the disabled compositing mode, which the evolution uses:
https://bugs.webkit.org/show_bug.cgi?id=166420#c9

There used to be an option, but it seems to be gone, thus it cannot be disabled, neither for the message preview, nor for the editor itself.
Comment 4 Milan Crha 2017-01-17 18:00:24 UTC
I added an option org.gnome.evolution.shell webkit-developer-mode to be able to enable it only on demand. The command might be:

   $ gsettings set org.gnome.evolution.shell webkit-developer-mode true

while the default is 'false'. Any changes of that property require restart of the evolution.

I would commit it also for the 3.22.5, but there are new translatable strings added, thus I asked for a String Freeze break approval.

Created commit 53fe9c0 in evo master (3.23.90+)
Comment 5 Michael Catanzaro 2017-01-17 18:22:46 UTC
(In reply to Milan Crha from comment #4)
> Any changes of that property require restart
> of the evolution.

Why not connect to GSettings::changed...?
Comment 6 Milan Crha 2017-01-17 18:56:17 UTC
Because I disable whole module on load and loading/unloading on the fly is a nightmare.
Comment 7 Jeremy Bicha 2017-01-17 19:40:10 UTC
Hi. you don't need to use "the" before Evolution. Here's a suggested rewording:

- <_description>The change of this option requires restart of the Evolution.</_description>
+ <_description>Restart Evolution if you change this setting.</_description>

Or "You must restart Evolution if you change this setting."
Comment 8 Milan Crha 2017-01-18 08:43:47 UTC
A word "option" is better than "setting" from my point of view. With respect of the 'the', I know I do not use them enough. It seems to me appropriate here, just like 'the application'. Edit->Plugins already contains a similar text: "Note: Some changes will not take effect until restart". I wanted to write something similar. In any case, this particular string is mostly invisible, doesn't touch Evolution's UI directly. Looking at it, a better than the initial would be:

    Any change of this option requires restart of the Evolution.
Comment 9 Jeremy Bicha 2017-01-18 09:32:55 UTC
Your proposed text is great but as a native English speaker, it's better without "the".

I'm not aware of any trademarked software like "Windows 10" or "Angry Birds" or "Microsoft Office" that normally has "the" in front of it.

However, this page points out that you would add "the" when you say "the Windows 10 updates" or "the Evolution plugins"

https://english.stackexchange.com/questions/222558/definite-article-before-specific-product-names

(On the other hand, I think it's also common to say "the Windows operating system" or "the Angry Birds app" or "the Microsoft Office suite".

I apologize for how confusing English is!
Comment 10 Milan Crha 2017-01-18 10:48:13 UTC
That's the 'of', which makes me feel like the 'the' being missing there, but I am not a native speaker, thus it's just a personal feeling. I changed the string to:

   Any change of this option requires restart of Evolution.

Created commit c44c895 in evo master (3.23.90+)

I also got an approval for the stable branch, thus (this time in one shot):

Created commit a870b0a in evo gnome-3-22 (3.22.5+)