After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776352 - dashdemux: Drain remaining buffer in adapter
dashdemux: Drain remaining buffer in adapter
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.11.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-12-21 14:35 UTC by Seungha Yang
Modified: 2016-12-22 12:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dashdemux: Drain remaining buffer in adapter (1.62 KB, patch)
2016-12-21 14:36 UTC, Seungha Yang 		committed Details | Review

Description Seungha Yang 2016-12-21 14:35:43 UTC 
Previous patch allows sidx box parsing from incoming buffers. 
Since the incoming buffer boundary might be over sidx box, 
there can be remaining buffer in isobmff parser adapter.
Comment 1 Seungha Yang 2016-12-21 14:36:28 UTC 
Created attachment 342320 [details] [review]
dashdemux: Drain remaining buffer in adapter
Comment 2 Sebastian Dröge (slomo) 2016-12-21 14:48:09 UTC 
Review of attachment 342320 [details] [review]:

::: ext/dash/gstdashdemux.c
@@ +2539,3 @@
+
+    /* Drain adapter */
+    gst_adapter_push (dash_stream->isobmff_adapter, buffer);

Why are you pushing the buffer in here? Isn't the buffer actually from the beginning of the adapter, not the end, and now you add it to the end?
Comment 3 Seungha Yang 2016-12-21 15:54:18 UTC 
(In reply to Sebastian Dröge (slomo) from comment #2)
> Review of attachment 342320 [details] [review] [review]:

> Why are you pushing the buffer in here? Isn't the buffer actually from the
> beginning of the adapter, not the end, and now you add it to the end?

Thanks to review.
My purpose was just to make one buffer (it looks good to me ...). In other words, that's to prevent pushing buffer twice :)
Comment 4 Sebastian Dröge (slomo) 2016-12-22 12:13:24 UTC 
Attachment 342320 [details] pushed as 998c8ce - dashdemux: Drain remaining buffer in adapter