After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776330 - Improve preview text generation
Improve preview text generation
Status: RESOLVED OBSOLETE
Product: geary
Classification: Other
Component: client+engine
master
Other Linux
: Normal normal
: ---
Assigned To: Geary Maintainers
Geary Maintainers
: 778789 (view as bug list)
Depends on: 713191 714317
Blocks:
 
 
Reported: 2016-12-21 01:00 UTC by Michael Gratton
Modified: 2021-07-05 13:24 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Michael Gratton 2016-12-21 01:00:22 UTC
When Bug 714317 lands, Geary will be doing the following when generating preview text:

- For text/html: Remove blockquotes, strip tags out and attempt to format as "readable" plain text
- For text/plain: Strip lines starting with common armour prefixes, remove inline PGP armour and headers, remove some common formatting artifacts

This could still be improved a bit:
 - Remove signature delims in plain text parts and everything after it
 - Unless the preview is short, strip any URLs out out if
 - Remove the attribution line before quote blocks, if any
 - Remove inline PGP signatures and other artifacts

And in general, see what stuff is in commonly found in emails that makes the previews sub-optimal, and work out if they can/should be removed.
Comment 1 Gautier Pelloux-Prayer 2016-12-21 09:15:16 UTC
Additionally, displaying unicode character '
Comment 2 Gautier Pelloux-Prayer 2016-12-21 09:16:28 UTC
Additionally, displaying unicode character 'U+1F5BC' (cf http://www.fileformat.info/info/unicode/char/1f5bc/index.htm) for inlined images could be great and/or if the email contains only attached images.

edit: oops, bugzilla does not like unicode character in comments! Do not try to insert one!
Comment 3 Michael Gratton 2016-12-23 01:04:38 UTC
(In reply to Gautier Pelloux-Prayer from comment #2)
> Additionally, displaying unicode character 'U+1F5BC' (cf
> http://www.fileformat.info/info/unicode/char/1f5bc/index.htm) for inlined
> images could be great and/or if the email contains only attached images.

Oh, this is an interesting idea. For HTML messages we're now displaying the alt text if found for IMG elements, which I think is the right thing to do. For plain text messages however this could be good.

I wonder if something similar could be done for Bug 712950 (i.e. for attachments in general), although since there is a pref for not showing previews, maybe not?
Comment 4 Gautier Pelloux-Prayer 2017-02-16 23:44:33 UTC
*** Bug 778789 has been marked as a duplicate of this bug. ***
Comment 5 GNOME Infrastructure Team 2021-07-05 13:24:44 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new ticket at
  https://gitlab.gnome.org/GNOME/geary/-/issues/

Thank you for your understanding and your help.