After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776327 - Replace deprecated GTK_STOCK
Replace deprecated GTK_STOCK
Status: RESOLVED OBSOLETE
Product: gtranslator
Classification: Other
Component: Build
2.91.x
Other Linux
: Normal normal
: ---
Assigned To: Muhammet Kara
gtranslator-maint
Depends on:
Blocks:
 
 
Reported: 2016-12-20 23:57 UTC by Muhammet Kara
Modified: 2019-02-27 15:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Get rid of deprecated GtkStockItem usages in gtr-window.c (6.42 KB, patch)
2016-12-21 00:04 UTC, Muhammet Kara
needs-work Details | Review
Replace deprecated GTK_STOCK in gtr-alternate-language-panel.c (master) (4.70 KB, patch)
2016-12-25 18:08 UTC, Muhammet Kara
none Details | Review

Description Muhammet Kara 2016-12-20 23:57:26 UTC
Since GTK 3.10 GTK_STOCK are deprecated and thus need to be replaced.
Comment 1 Muhammet Kara 2016-12-21 00:04:10 UTC
Created attachment 342289 [details] [review]
Get rid of deprecated GtkStockItem usages in gtr-window.c

This patch silences some compile warnings by replacing deprecated GTK_STOCK_* instances with their corresponding named icons and/or labels.

There are more GTK_STOCK usages in the project (also in master).

I would like to replace all of them, once this patch gets reviewed (so I'll  know I am doing it right)
Comment 2 Alexandre Franke 2016-12-21 20:09:28 UTC
Review of attachment 342289 [details] [review]:

This patch doesn't apply on master.
Comment 3 Muhammet Kara 2016-12-21 21:05:21 UTC
(In reply to Alexandre Franke from comment #2)
> Review of attachment 342289 [details] [review] [review]:
> 
> This patch doesn't apply on master.

Sorry, I forgot to mention that this patch was for 2-91 branch.
Comment 4 Muhammet Kara 2016-12-25 18:08:37 UTC
Created attachment 342467 [details] [review]
Replace deprecated GTK_STOCK in gtr-alternate-language-panel.c (master)
Comment 5 André Klapper 2019-02-27 15:16:06 UTC
We are mass-closing old gtranslator issues as the latest versions of gtranslator (3.30 or later) should fix most of the reported problems and as there is unfortunately no capacity to retest all of them separately.
https://mail.gnome.org/archives/desktop-devel-list/2019-February/msg00059.html

If the issue described in this report still happens in gtranslator version 3.30 or later, please file a new ticket under https://gitlab.gnome.org/GNOME/gtranslator/issues/ - thanks for your understanding!

We are sorry that your report was not handled / fixed after you reported it - many free and open source software projects receive more bug reports and feature requests than they have developers who have free time to work on them.
If you would like to get involved and contribute on gtranslator code, please check https://wiki.gnome.org/Git/Developers