GNOME Bugzilla – Bug 776314
rtspsrc: suggest multicast but do not require it
Last modified: 2018-11-03 15:15:02 UTC
Created attachment 342267 [details] logs rtsp stream from a particular camera works fine with vlc but not with gstreamer, here are the relevant manufacter documentation """ The RTSP server handles SETUP requests with multiple transport suggestions. The first transport possible will be chosen by the server. This allows a client to implement a seamless automatic ‘prefer multicast over unicast’ scenario. This in turn yields a system that makes efficient use of bandwidth if possible (multicast), while still guaranteeing delivery of video if not (unicast). To do so, a client needs to specify a multicast transport first and unicast as second, as fallback option. If the encoder has a multicast stream available, it responds with the multicast connection parameters. If it hasn't, it responds with unicast connection parameters. Not every RTSP client available supports this behaviour """ If a multicast address is given inside the sdp gstreamer only try multicast and if no data can be received it errors out this way: Could not connect to server, no protocols left gstreamer logs attached
Created attachment 342268 [details] [review] proposed fix this patch solves the issue
Review of attachment 342268 [details] [review]: ::: gst/rtsp/gstrtspsrc.c @@ +6046,2 @@ if (stream->is_multicast) + protocols |= GST_RTSP_LOWER_TRANS_UDP_MCAST; This seems wrong. You now allow multicast even if protocols (as set via the property) did not allow it. Or am I missing something?
yes, this is probably wrong, actually if multicast is detected inside sdp other protocols set via the property are excluded, maybe we should remove this line?
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/332.