After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776280 - validate-scenario: Properly get the rate for action validation
validate-scenario: Properly get the rate for action validation
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-devtools
unspecified
Other All
: Normal normal
: 1.10.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-12-19 15:30 UTC by Edward Hervey
Modified: 2016-12-19 15:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
validate-scenario: Properly get the rate for action validation (2.73 KB, patch)
2016-12-19 15:30 UTC, Edward Hervey 		committed Details | Review

Description Edward Hervey 2016-12-19 15:30:34 UTC 
See comment
Comment 1 Edward Hervey 2016-12-19 15:30:40 UTC 
Created attachment 342222 [details] [review]
validate-scenario: Properly get the rate for action validation

This issue was most likely introduced by the refactoring of the
position querying into a standalone function.

In execute_next_action() the rate variable was never replaced by
the current rate of the pipeline, this would result in all reverse
playback actions to trigger immediately instead of waiting for
the actual target time.
Comment 2 Thibault Saunier 2016-12-19 15:35:04 UTC 
Review of attachment 342222 [details] [review]:

We should add unit tests, but yes, this is correct.
Comment 3 Edward Hervey 2016-12-19 15:46:58 UTC 
commit 5eab79dbd343eb6fda84262a0096f79943e93b9a
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Mon Dec 19 16:17:56 2016 +0100

    validate-scenario: Properly get the rate for action validation
    
    This issue was most likely introduced by the refactoring of the
    position querying into a standalone function.
    
    In execute_next_action() the rate variable was never replaced by
    the current rate of the pipeline, this would result in all reverse
    playback actions to trigger immediately instead of waiting for
    the actual target time.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=776280