After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776236 - FDK-AAC plugin does not expose LATM/LOAS transmux support
FDK-AAC plugin does not expose LATM/LOAS transmux support
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-12-18 13:39 UTC by Rafael Diniz
Modified: 2018-11-03 14:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Rafael Diniz 2016-12-18 13:39:35 UTC 
FDK-AAC does support LATM/LOAS muxing, but gstreamer plugin does not. LATM/LOAS mux is widelly used worldwide in ISDB-T DTV.
Comment 1 Sebastian Dröge (slomo) 2016-12-19 09:03:15 UTC 
Are you planning to work on this?
Comment 2 Rafael Diniz 2016-12-19 15:09:12 UTC 
Yes. I'm trying to generate a compliant ISDB-T Transport Stream (MPEG2-TS).
Comment 3 Rafael Diniz 2016-12-20 15:55:10 UTC 
I did a first patch towards LOAS support in the encoder.
https://github.com/rafael2k/gst-plugins-bad/commit/38ecd8b83b22b9676800c175f2b1523f9a1a35dc

Also pasted here:

index 5e67d80..c20d4fb 100644
--- a/ext/fdkaac/gstfdkaacenc.c
+++ b/ext/fdkaac/gstfdkaacenc.c
@@ -133,7 +133,7 @@ static GstStaticPadTemplate src_template = GST_STATIC_PAD_TEMPLATE ("src",
         "mpegversion = (int) 4, "
         "rate = (int) { " SAMPLE_RATES " }, "
         "channels = (int) {1, 2, 3, 4, 5, 6, 8}, "
-        "stream-format = (string) { adts, adif, raw }, "
+        "stream-format = (string) { adts, adif, loas, raw }, "
         "base-profile = (string) lc, " "framed = (boolean) true")
     );
 
@@ -281,6 +281,9 @@ gst_fdkaacenc_set_format (GstAudioEncoder * enc, GstAudioInfo * info)
       } else if (strcmp (str, "adif") == 0) {
         GST_DEBUG_OBJECT (self, "use ADIF format for output");
         transmux = 1;
+      } else if (strcmp (str, "loas") == 0) {
+        GST_DEBUG_OBJECT (self, "use LOAS format for output");
+        transmux = 10;
       } else if (strcmp (str, "raw") == 0) {
         GST_DEBUG_OBJECT (self, "use RAW format for output");
         transmux = 0;
Comment 4 Sebastian Dröge (slomo) 2016-12-21 07:59:35 UTC 
Does it work, what is missing? Does the resulting stream work fine through aacparse?
Comment 5 GStreamer system administrator 2018-11-03 14:02:01 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/497.