After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776134 - status-notifier: Keyboard interaction support
status-notifier: Keyboard interaction support
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-12-15 13:13 UTC by Colomban Wendling
Modified: 2016-12-18 13:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
status-notifier: add support for keyboard activation (4.26 KB, patch)
2016-12-15 13:13 UTC, Colomban Wendling
none Details | Review
status-notifier: add support for keyboard activation (4.51 KB, patch)
2016-12-15 13:36 UTC, Colomban Wendling
committed Details | Review

Description Colomban Wendling 2016-12-15 13:13:49 UTC
Created attachment 342021 [details] [review]
status-notifier: add support for keyboard activation

Attached patch adds support for keyboard activation of the status-notifier items.

* activating the items (return, space, etc.) work the same as left mouse click (activate).
* menu key, shift-f10, etc. work the same as right mouse click (popup menu).
Comment 1 Colomban Wendling 2016-12-15 13:36:58 UTC
Created attachment 342025 [details] [review]
status-notifier: add support for keyboard activation

Updated patch not to emit activate twice.

I initially though that the GtkWidget::button_press_event override would prevent GtkButton::clicked from being emitted, but that's not true anymore now GtkButton uses GtkGesture internally instead of a GtkWidget::button_press_event override.
So, remove the custom handling of left mouse click and leave this to GtkButton::clicked override, not to send "activate" twice.
Comment 2 Alberts Muktupāvels 2016-12-18 13:53:50 UTC
Thanks!