After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776133 - GdMainView: The DnD selection counter is broken on HiDpi
GdMainView: The DnD selection counter is broken on HiDpi
Status: RESOLVED FIXED
Product: libgd
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: libgd maintainer(s)
libgd maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-12-15 12:33 UTC by Debarshi Ray
Modified: 2016-12-15 22:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
main-view: Don't let the Cairo surface get bigger while copying (1.76 KB, patch)
2016-12-15 12:47 UTC, Debarshi Ray 		none Details | Review
main-view: Fix the size and offset of the counter icon on HiDpi (3.41 KB, patch)
2016-12-15 13:16 UTC, Debarshi Ray 		committed Details | Review
main-view: Don't let the Cairo surface get bigger while copying (1.86 KB, patch)
2016-12-15 13:18 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2016-12-15 12:33:23 UTC 
GdMainView draws an emblem with a number if you are DnDing multiple items from the selection mode. The emblem looks very big and is placed far away from the mouse cursor on HiDpi.

At least part of the bug arises from the Cairo documentation either being wrong or being incomplete. See: https://bugs.freedesktop.org/show_bug.cgi?id=99094
Comment 1 Debarshi Ray 2016-12-15 12:47:53 UTC 
Created attachment 342020 [details] [review]
main-view: Don't let the Cairo surface get bigger while copying
Comment 2 Debarshi Ray 2016-12-15 13:16:55 UTC 
Created attachment 342023 [details] [review]
main-view: Fix the size and offset of the counter icon on HiDpi
Comment 3 Debarshi Ray 2016-12-15 13:18:11 UTC 
Created attachment 342024 [details] [review]
main-view: Don't let the Cairo surface get bigger while copying

Fix a typo in the commit message.
Comment 4 Cosimo Cecchi 2016-12-15 19:13:30 UTC 
Review of attachment 342023 [details] [review]:

OK, thanks.
Comment 5 Cosimo Cecchi 2016-12-15 19:13:56 UTC 
Review of attachment 342024 [details] [review]:

OK
Comment 6 Debarshi Ray 2016-12-15 22:50:25 UTC 
Thanks for the reviews!