GNOME Bugzilla – Bug 776029
Inbox never prefetched/sync'ed
Last modified: 2017-01-16 09:06:59 UTC
From the mailing list: https://mail.gnome.org/archives/geary-list/2016-December/msg00012.html > Hi, > > from my testing, the prefetch_period_days does not work for INBOX. > This is annoying, I want to prefetch all my e-mail, so I can run searches. > > As far as I could, I've traced the problem down to this condition in > send_all: > > if (imap_folder.get_open_state() != Folder.OpenState.CLOSED) > continue; > > https://github.com/GNOME/geary/blob/master/src/engine/imap-engine/imap-engine-account-synchronizer.vala#L151 > > INBOX is always open and thus is never sent to process_queue_async. > > I've tried removing that condition and it _seems_ to work OK. > From the comment in that block, it's not clear whether that condition > is just a performance optimization or it there's a possible consistency > issue lurking. > > Ricardo
Created attachment 341857 [details] [review] Fix Inbox never being prefetched, since it is never sync'ed
I've tried it and indeed it works much better with the patch. Previously I was stuck at 50 from 9500 emails being fetched. With the patch, all INBOX emails have been downloaded! Hourray!
Okay, cool. I've pushed this to master as commit 58efb70, will let it get some further testing there for a while and then cherry pick onto geary-0.11.
Fix cherry-picked to geary-0.11 and pushed as commit 1bc3251.
Hello, does this fix apply to any other folder apart from Inbox? I have some folders in an IMAP account and only the first ones are retrieved. If there are enough to scroll then the rest are retrieved when scrolling but if there's not enough messages prefetched I have to reduce the size of the window to force scrolling and then scroll until all are fetched. Doesn't this patch address this?
(In reply to Jose from comment #5) > Hello, does this fix apply to any other folder apart from Inbox? Technically yes, but not really in practice. Can you please open another bug so we can look into this?
I already opened it a couple of months ago: https://bugzilla.gnome.org/show_bug.cgi?id=773508