Created attachment 341825 [details] [review]
thumbnail: Remove gnome_desktop_thumbnail_scale_down_pixbuf()

gnome-desktop is not a general purpose library for use by application
developers, but rather a convenience library for core desktop components
to share code. As such, it has no guarantee of API stability, and we can
remove functions without having to obsolete them.

Having said that, the internal user of this function was removed in bug
768064, and external users should be using the default gdk-pixbuf
scaling functions. If specific changes need to be made to those, they'll
need to be handled separately.

Epiphany uses this, are you able to help with the migration...?

(In reply to Michael Catanzaro from comment #2)
> Epiphany uses this, are you able to help with the migration...?

The solution is to just use gdk_pixbuf_scale_simple instead.

Created attachment 343037 [details] [review]
thumbnail: Deprecate gnome_desktop_thumbnail_scale_down_pixbuf()

(In reply to Michael Catanzaro from comment #3)
> (In reply to Michael Catanzaro from comment #2)
> > Epiphany uses this, are you able to help with the migration...?
> 
> The solution is to just use gdk_pixbuf_scale_simple instead.

Can you verify that you get a warning about the deprecation with this new patch?

If that's good enough, I'll bump the gdk-pixbuf requirement and push this for GNOME 3.24.

Looks like the patch doesn't apply on gdk-pixbuf master?

It's a gnome-desktop patch

(In reply to Bastien Nocera from comment #7)
> It's a gnome-desktop patch

Um, yup.

/home/mcatanzaro/src/jhbuild/checkout/epiphany/lib/ephy-snapshot-service.c: In function ‘ephy_snapshot_service_prepare_snapshot’:
/home/mcatanzaro/src/jhbuild/checkout/epiphany/lib/ephy-snapshot-service.c:138:5: warning: ‘gnome_desktop_thumbnail_scale_down_pixbuf’ is deprecated: Use 'gdk_pixbuf_scale_simple' instead [-Wdeprecated-declarations]
     scaled = gnome_desktop_thumbnail_scale_down_pixbuf (snapshot,
     ^~~~~~
In file included from /home/mcatanzaro/src/jhbuild/checkout/epiphany/lib/ephy-snapshot-service.c:29:0:
/home/mcatanzaro/src/jhbuild/install/include/gnome-desktop-3.0/libgnome-desktop/gnome-desktop-thumbnail.h:113:12: note: declared here
 GdkPixbuf *gnome_desktop_thumbnail_scale_down_pixbuf (GdkPixbuf          *pixbuf,
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Looks good.

Great, works as planned. Let's wait for the gdk-pixbuf changes to land.

Created attachment 344876 [details] [review]
thumbnail: Deprecate gnome_desktop_thumbnail_scale_down_pixbuf()

As scaling down by huge factors is now fixed in gdk-pixbuf. Require the
newer gdk-pixbuf as well, to avoid running into a pre-fix version.

Attachment 344876 [details] pushed as cb64228 - thumbnail: Deprecate gnome_desktop_thumbnail_scale_down_pixbuf()