After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775929 - Turn DiscListBox into a GtkBox subclass
Turn DiscListBox into a GtkBox subclass
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2016-12-10 13:35 UTC by Georges Basile Stavracas Neto
Modified: 2016-12-10 16:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
disclistbox: Turn into a GtkBox subclass (2.75 KB, patch)
2016-12-10 13:36 UTC, Georges Basile Stavracas Neto
none Details | Review
disclistbox: Turn into a GtkBox subclass (3.36 KB, patch)
2016-12-10 13:55 UTC, Georges Basile Stavracas Neto
committed Details | Review

Description Georges Basile Stavracas Neto 2016-12-10 13:35:58 UTC
See the patch below.
Comment 1 Georges Basile Stavracas Neto 2016-12-10 13:36:04 UTC
Created attachment 341718 [details] [review]
disclistbox: Turn into a GtkBox subclass

The current disc list implementation uses a GtkListBox as
the parent class. This brings some issues with it, as the
listbox widget has selectable, focusable rows that break
the keyboard navigation. The listbox rows also handle clicks
and add a strange effect to the disc list when clicking
outside the songs list.

Fix this by using GtkBox as the base class of DiscListBox,
and the keyboard and clicking issues are all gone.
Comment 2 Georges Basile Stavracas Neto 2016-12-10 13:55:21 UTC
Created attachment 341719 [details] [review]
disclistbox: Turn into a GtkBox subclass

Fixed a minor issue with the Artists view.
Comment 3 Marinus Schraal 2016-12-10 16:34:12 UTC
Comment on attachment 341719 [details] [review]
disclistbox: Turn into a GtkBox subclass

Pushed with a minor addition. Thanks for the patch.