GNOME Bugzilla – Bug 775870
Update libcheck to the latest upstream 0.10.0 (git)
Last modified: 2016-12-09 10:35:24 UTC
libcheck doesn't seem to do releases anymore, but we need the latest code from upstream[1] to add support for running gstreamer tests on Windows when built with MSVC. 1. https://github.com/libcheck/check/ The attached patches do this in four steps: * Update the libcheck code to latest git * Move libcompat files to a new subdir * Update existing libcompat files and copy new ones * Build (autotools and meson) changes needed to use all this Once this is merged, we can work on making the tests work on Windows/MSVC which will require more patches to libcheck. I have already talked to upstream about upstreaming such patches.
Created attachment 341664 [details] [review] libcheck: port to latest check git Upstream seems to have stopped doing releases, but we need to update for better Windows and Visual Studio support. This patch only updates the libcheck sources and ignores the compatibility sources for now.
Created attachment 341665 [details] [review] libcheck: Just move libcompat files to a subdir Makes it clearer which files are actually used in libcheck and which are used for cross-platform compatibility. This is going to be especially useful when we add all the libcompat fallback code that upstream libcheck has which will add about 6 new files.
Created attachment 341666 [details] [review] libcheck: Update the compatibility code and checks This brings us up-to-speed with the latest compatibility code from upstream check git. For completeness, we do all the checks that upstream check does, but we skip the snprintf/vsnprintf code because it's not straightforward (involves running code and that is bad for cross-compilation) and not necessary for the platforms we support anyway. If someone really wants this, they can uncomment this and copy the relevant checks from the check git repository.
Comment on attachment 341664 [details] [review] libcheck: port to latest check git Please push but put a README there on which version it is exactly based on
Comment on attachment 341665 [details] [review] libcheck: Just move libcompat files to a subdir Upstream also has it in a separate subdirectory? Diverging from upstream directory layout seems suboptimal otherwise
Comment on attachment 341666 [details] [review] libcheck: Update the compatibility code and checks If this is just a copy from upstream, all good. Otherwise please put in the README (see above) a diff and explanation so we know what to update next time :)
Upstream has always had the check sources and the compat lib in separate directories. I'm not sure why it was flattened when we copied it over: https://github.com/libcheck/check/tree/master/src (libcheck) https://github.com/libcheck/check/tree/master/lib (libcompat) Will add a README and push this. Thanks for the ACK!
README.txt added and everything pushed. Attachment 341664 [details] pushed as 0bb6d59 - libcheck: port to latest check git Attachment 341665 [details] pushed as eb1f861 - libcheck: Just move libcompat files to a subdir Attachment 341666 [details] pushed as d8e8e92 - libcheck: Update the compatibility code and checks