After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775857 - [PATCH] New blending modes: Vivid light, Linear light and Pin light
[PATCH] New blending modes: Vivid light, Linear light and Pin light
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: General
git master
Other All
: Normal enhancement
: 2.10
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2016-12-08 19:13 UTC by Thomas Manni
Modified: 2017-02-02 20:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add vivid light, linear light and pin light blending modes (36.16 KB, patch)
2016-12-08 19:13 UTC, Thomas Manni
none Details | Review

Description Thomas Manni 2016-12-08 19:13:48 UTC
Created attachment 341643 [details] [review]
Add vivid light, linear light and pin light blending modes

About the patch:

* I use a different equation for blending/compositing ; it seems to avoid issues related to semi-transparent pixels present in the backdrop (see bug https://bugzilla.gnome.org/show_bug.cgi?id=775653)

* Current equations for the 3 blending modes seem to work correctly only with perceptual gamma image

* I don't have any "reference" to test if these blending modes give the expected result, so testers feedback are welcome
Comment 1 Jehan 2016-12-09 02:59:27 UTC
Thanks for this!

What are the specification/paper references for these 3 blending modes? I could find some stuff on the web, but nothing which looked normative. That's hard to review if we don't know what we should check against. :-)
Comment 2 Alexandre Prokoudine 2017-01-03 17:18:46 UTC
Jehan, you could use google-translated version of http://zhur74.livejournal.com/15544.html :)

In a nutshell:

Vivid Light burns with Color Burn and dodges using Color Dodge at the same time.

Linear Light is 2 x Linear Burn and 2 x Linear Dodge combination respectively.

Pin Light is Darken and Lighten combination respectively.

There's also a short description at https://helpx.adobe.com/photoshop/using/blending-modes.html.
Comment 3 Øyvind Kolås (pippin) 2017-01-22 13:10:54 UTC
Before seeing this bug report - but seeing people asking for some of these blend modes on the mailinglist, I added innerloop functions for the new separated compositing/blending infrastructure to do these (and some more) blend modes,
innerloops only for now - they are not fully hooked up to the UI yet.

commit c9ad09df6195e6ed59f3ece17b055eaed5891e22
Author: Øyvind Kolås <pippin@gimp.org>
Date:   Sun Jan 22 13:40:20 2017 +0100

    app: add a handful more blending innerloops
    
    Adding linear burn, vivid light, linear light, pinlight and exclusion formulas
    as described on
    http://www.deepskycolors.com/archivo/2010/04/21/formulas-for-Photoshop-blending-modes.html
Comment 4 Michael Natterer 2017-02-02 20:56:33 UTC
Comment on attachment 341643 [details] [review]
Add vivid light, linear light and pin light blending modes

This was done using the new framework, this patch is no longer needed.
Comment 5 Michael Natterer 2017-02-02 20:57:04 UTC
The modes are now accessible from the UI.