After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775846 - gdk/wayland: Add support for the gtk-enable-primary-paste gsetting
gdk/wayland: Add support for the gtk-enable-primary-paste gsetting
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Wayland
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on: 775844
Blocks:
 
 
Reported: 2016-12-08 17:24 UTC by Rui Matos
Modified: 2017-01-10 14:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gdk/wayland: Add support for the gtk-enable-primary-paste gsetting (1.50 KB, patch)
2016-12-08 17:24 UTC, Rui Matos
committed Details | Review
gdk/wayland: Handle non-existant gsettings keys (9.22 KB, patch)
2017-01-09 16:56 UTC, Rui Matos
committed Details | Review

Description Rui Matos 2016-12-08 17:24:53 UTC
.
Comment 1 Rui Matos 2016-12-08 17:24:57 UTC
Created attachment 341626 [details] [review]
gdk/wayland: Add support for the gtk-enable-primary-paste gsetting

The gsetting was recently added so that we can have this configurable
on the wayland backend too.
Comment 2 Matthias Clasen 2016-12-08 18:10:57 UTC
Review of attachment 341626 [details] [review]:

sure, looks good
Comment 3 Matthias Clasen 2016-12-08 18:11:04 UTC
Review of attachment 341626 [details] [review]:

sure, looks good
Comment 4 Rui Matos 2017-01-09 16:56:45 UTC
Created attachment 343170 [details] [review]
gdk/wayland: Handle non-existant gsettings keys

Since we're a library, crashing on gsettings keys, whose presence is out
of our control, isn't appropriate.
--

I was going to push but realized that unlike other modules, I don't
think gtk+ (particularly the 3-22 branch) can depend on a new enough
gsettings-desktop-schemas, so I think we'll need something like this
patch too.
Comment 5 Matthias Clasen 2017-01-09 20:37:12 UTC
Review of attachment 343170 [details] [review]:

ok
Comment 6 Rui Matos 2017-01-10 14:20:36 UTC
eece8a7..99abc63  gtk-3-22 -> gtk-3-22
   57a11ca..ae61220  master -> master

Attachment 341626 [details] pushed as b46da27 - gdk/wayland: Add support for the gtk-enable-primary-paste gsetting
Attachment 343170 [details] pushed as ae61220 - gdk/wayland: Handle non-existant gsettings keys

Slightly changed this one to use the translation entry's fallback
value instead of making gdk_screen_get_setting() fail for these
cases.