After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775765 - FDO notification withdrawal backend sends wrong ID to the server
FDO notification withdrawal backend sends wrong ID to the server
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
2.48.x
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2016-12-07 18:22 UTC by donadigo
Modified: 2016-12-07 20:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fixes the notify ID in the g_fdo_notification_backend_withdraw_notification method (1.03 KB, patch)
2016-12-07 18:34 UTC, donadigo 		committed Details | Review

Description donadigo 2016-12-07 18:22:50 UTC 
The backend of withdrawing notification in FDO implementation as seen here:
https://git.gnome.org/browse/glib/tree/gio/gfdonotificationbackend.c#n427

Instead of sending real ID, which is "notify_id", GLib sends it's internal string ID printed as uint32, which results in an incorrect ID sent to the server.
Comment 1 donadigo 2016-12-07 18:34:24 UTC 
Created attachment 341573 [details] [review]
Fixes the notify ID in the g_fdo_notification_backend_withdraw_notification method
Comment 2 Christian Hergert 2016-12-07 20:39:03 UTC 
Review of attachment 341573 [details] [review]:

LGTM. The ->id is clearly wrong for (u) since it's a pointer being passed to a varargs function wanting a uint.
Comment 3 Christian Hergert 2016-12-07 20:40:56 UTC 
Thanks!