After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775735 - language-specs: Add HAXE language specification
language-specs: Add HAXE language specification
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: Syntax files
3.20.x
Other Linux
: Normal enhancement
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2016-12-07 01:22 UTC by Wolfang Alfredo
Modified: 2016-12-08 08:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
path that adds all the necesary files to include the haxe languaje (9.86 KB, patch)
2016-12-07 01:35 UTC, Wolfang Alfredo 		none Details | Review
language-specs: Add HAXE language specification (10.31 KB, patch)
2016-12-07 03:16 UTC, Wolfang Alfredo 		none Details | Review
language-specs: Add HAXE language specification (10.26 KB, patch)
2016-12-07 22:24 UTC, Wolfang Alfredo 		none Details | Review

Description Wolfang Alfredo 2016-12-07 01:22:15 UTC 
This is a style for the Haxe programing language
https://haxe.org/

"Haxe is an open source toolkit based on a modern, high level,
strictly typed programming language."
Comment 1 Wolfang Alfredo 2016-12-07 01:35:06 UTC 
Created attachment 341525 [details] [review]
path that adds all the necesary files to include the haxe languaje

it adds the haxe.lang description, but also test/syntax-hightlights/file.hx and modifes data/languaje-scpecs/MAkefile.am and po/POTFILES.skip
Comment 2 Wolfang Alfredo 2016-12-07 03:16:12 UTC 
Created attachment 341526 [details] [review]
language-specs: Add HAXE language specification

Fixed use of tabs and spaces in file
Comment 3 Sébastien Wilmet 2016-12-07 11:40:21 UTC 
Review of attachment 341526 [details] [review]:

Looks mostly good. Some comments below.

::: data/language-specs/haxe.lang
@@ +5,3 @@
+
+ Author: Ian Liu Rodrigues <ian.liu88@gmail.com> (modified from java.xml)
+ Copyright (C) 2003 Gustavo Giráldez <gustavo.giraldez@gmx.net>

Is the file encoded in UTF-8?

@@ +33,3 @@
+-->
+
+<language id="haxe" _name="Haxe" version="2.0" _section="Sources">

The section should be "Source", not "Sources". The sections have been renamed several years ago.

@@ +241,3 @@
+</language>
+
+

No need to have blank lines at the end of the file. The file should just end with a single \n.
Comment 4 Wolfang Alfredo 2016-12-07 22:24:47 UTC 
Created attachment 341586 [details] [review]
language-specs: Add HAXE language specification
Comment 5 Sébastien Wilmet 2016-12-08 08:36:51 UTC 
Thanks, pushed as commit 406dc8c2c056fc8b92e6a9574bd0d00480c641d2.
And cherry-picked on the gnome-3-24 branch.

(there is a problem with the Author in the git commit, please check your git configuration.)