After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775719 - language-specs: Add ABNF language specification
language-specs: Add ABNF language specification
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: Syntax files
unspecified
Other All
: Normal normal
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2016-12-06 17:10 UTC by Philip Withnall
Modified: 2016-12-06 20:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
language-specs: Add ABNF language specification (5.39 KB, patch)
2016-12-06 17:10 UTC, Philip Withnall 		none Details | Review
language-specs: Add ABNF language specification (6.09 KB, patch)
2016-12-06 20:09 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2016-12-06 17:10:43 UTC 
Attached.
Comment 1 Philip Withnall 2016-12-06 17:10:47 UTC 
Created attachment 341498 [details] [review]
language-specs: Add ABNF language specification

This is a style for Augmented Backus–Naur Form, as defined in RFC 5234:
 • https://tools.ietf.org/html/rfc5234
 • https://en.wikipedia.org/wiki/Augmented_Backus%E2%80%93Naur_form
Comment 2 Sébastien Wilmet 2016-12-06 19:02:01 UTC 
Review of attachment 341498 [details] [review]:

Looks good. Can you also add a test file in tests/syntax-highlighting/ ? (those are not unit tests, unfortunately, we just open those files in a text editor to have an example).
Comment 3 Philip Withnall 2016-12-06 20:09:13 UTC 
Created attachment 341503 [details] [review]
language-specs: Add ABNF language specification

This is a style for Augmented Backus–Naur Form, as defined in RFC 5234:
 • https://tools.ietf.org/html/rfc5234
 • https://en.wikipedia.org/wiki/Augmented_Backus%E2%80%93Naur_form
Comment 4 Sébastien Wilmet 2016-12-06 20:14:52 UTC 
Review of attachment 341503 [details] [review]:

Thanks!
Comment 5 Philip Withnall 2016-12-06 20:38:28 UTC 
t branch -d abn	
Pushed. Thanks for the super-fast reviews!

Attachment 341503 [details] pushed as 7a67b17 - language-specs: Add ABNF language specification