After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775701 - Improve opencv motion detection element
Improve opencv motion detection element
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-12-06 12:01 UTC by Will Newton
Modified: 2018-11-03 14:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-ext-opencv-MotionCells.h-Simplify-getIsNonZero.patch (1.00 KB, patch)
2016-12-06 12:03 UTC, Will Newton
none Details | Review
0002-ext-opencv-MotionCells.cpp-Use-int-for-counts-in-cal.patch (1.62 KB, patch)
2016-12-06 12:04 UTC, Will Newton
none Details | Review
0003-ext-opencv-MotionCells.cpp-Use-stack-rather-than-hea.patch (1.33 KB, patch)
2016-12-06 12:04 UTC, Will Newton
none Details | Review
0004-ext-opencv-MotionCells.cpp-Avoid-a-clone-of-the-curr.patch (1.17 KB, patch)
2016-12-06 12:04 UTC, Will Newton
none Details | Review
0005-ext-opencv-MotionCells.cpp-Avoid-a-clone-of-the-diff.patch (1.11 KB, patch)
2016-12-06 12:05 UTC, Will Newton
none Details | Review
0006-ext-opencv-MotionCells.cpp-Simplify-motion-percent-c.patch (1.14 KB, patch)
2016-12-06 12:05 UTC, Will Newton
none Details | Review
0007-ext-opencv-MotionCells.cpp-Avoid-downscaling-previou.patch (3.79 KB, patch)
2016-12-06 12:06 UTC, Will Newton
none Details | Review
0008-ext-opencv-MotionCells.cpp-Remove-unused-includes.patch (837 bytes, patch)
2016-12-06 12:06 UTC, Will Newton
none Details | Review
0009-ext-opencv-MotionCells.cpp-Remove-m_-prefix-from-loc.patch (3.57 KB, patch)
2016-12-06 12:07 UTC, Will Newton
none Details | Review
0010-ext-opencv-MotionCells.h-Remove-dead-code.patch (977 bytes, patch)
2016-12-06 12:08 UTC, Will Newton
none Details | Review

Description Will Newton 2016-12-06 12:01:49 UTC
This series of patches attempts to improve the performance of the plugin and also a few more cosmetic improvements along the way. There are still opportunities for improving the plugin further but hopefully this is a step in the right direction.
Comment 1 Will Newton 2016-12-06 12:03:26 UTC
Created attachment 341464 [details] [review]
0001-ext-opencv-MotionCells.h-Simplify-getIsNonZero.patch
Comment 2 Will Newton 2016-12-06 12:04:01 UTC
Created attachment 341465 [details] [review]
0002-ext-opencv-MotionCells.cpp-Use-int-for-counts-in-cal.patch
Comment 3 Will Newton 2016-12-06 12:04:25 UTC
Created attachment 341466 [details] [review]
0003-ext-opencv-MotionCells.cpp-Use-stack-rather-than-hea.patch
Comment 4 Will Newton 2016-12-06 12:04:56 UTC
Created attachment 341467 [details] [review]
0004-ext-opencv-MotionCells.cpp-Avoid-a-clone-of-the-curr.patch
Comment 5 Will Newton 2016-12-06 12:05:22 UTC
Created attachment 341468 [details] [review]
0005-ext-opencv-MotionCells.cpp-Avoid-a-clone-of-the-diff.patch
Comment 6 Will Newton 2016-12-06 12:05:55 UTC
Created attachment 341469 [details] [review]
0006-ext-opencv-MotionCells.cpp-Simplify-motion-percent-c.patch
Comment 7 Will Newton 2016-12-06 12:06:25 UTC
Created attachment 341470 [details] [review]
0007-ext-opencv-MotionCells.cpp-Avoid-downscaling-previou.patch
Comment 8 Will Newton 2016-12-06 12:06:58 UTC
Created attachment 341471 [details] [review]
0008-ext-opencv-MotionCells.cpp-Remove-unused-includes.patch
Comment 9 Will Newton 2016-12-06 12:07:31 UTC
Created attachment 341472 [details] [review]
0009-ext-opencv-MotionCells.cpp-Remove-m_-prefix-from-loc.patch
Comment 10 Will Newton 2016-12-06 12:08:02 UTC
Created attachment 341473 [details] [review]
0010-ext-opencv-MotionCells.h-Remove-dead-code.patch
Comment 11 Will Newton 2016-12-06 12:08:50 UTC
In my tests the CPU time is roughly halved after applying this series.
Comment 12 GStreamer system administrator 2018-11-03 14:01:12 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/489.