After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775695 - AppFavorites: add GNOME Calculator to the renamed desktop list
AppFavorites: add GNOME Calculator to the renamed desktop list
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2016-12-06 10:55 UTC by Niels De Graef
Modified: 2017-02-06 08:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[Patch] Add org.gnome.Calculator as renamed desktop file. (983 bytes, patch)
2016-12-06 10:55 UTC, Niels De Graef
reviewed Details | Review
AppFavorites: order alphabetically by key (1.00 KB, patch)
2017-02-06 07:41 UTC, Robert Roth
accepted-commit_now Details | Review

Description Niels De Graef 2016-12-06 10:55:02 UTC
Created attachment 341457 [details] [review]
[Patch] Add org.gnome.Calculator as renamed desktop file.

GNOME Calculator renamed its desktop file to follow the latest conventions (which makes it better for flatpak) to org.gnome.Calculator (bug 775056). Installing from master means having a duplicate entry in GNOME shell, which is the reason for this patch.

Maybe this could be landed together with bug 775507 (same thing, but for Geary)?
Comment 1 Florian Müllner 2016-12-07 14:33:38 UTC
Review of attachment 341457 [details] [review]:

::: js/ui/appFavorites.js
@@ +22,3 @@
     'gnome-boxes.desktop': 'org.gnome.Boxes.desktop',
     'gnome-clocks.desktop': 'org.gnome.clocks.desktop',
+    'gnome-calculator.desktop': 'org.gnome.Calculator.desktop',

It doesn't *really* matter, but the list is currently sorted alphabetically by key ...

Also: Bonus points for calculator for being the first app to appear more than once in the list ...
Comment 2 Jeremy Bicha 2017-02-06 06:56:09 UTC
Reminder ping since this change should be in GNOME 3.24.
Comment 3 Robert Roth 2017-02-06 07:41:08 UTC
Created attachment 345017 [details] [review]
AppFavorites: order alphabetically by key
Comment 4 Robert Roth 2017-02-06 07:43:14 UTC
The initial patch (or the same thing done by another user) was already committed, see
https://git.gnome.org/browse/gnome-shell/commit/?id=cdd23d9cc70bb1b042cc07d3d21c1a26aba479f9

My patch does the reordering on the current master accoring to Florian's review, after having it committed, we can close this.
Comment 5 Florian Müllner 2017-02-06 08:45:46 UTC
Review of attachment 345017 [details] [review]:

Sure
Comment 6 Robert Roth 2017-02-06 08:47:56 UTC
This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.