After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775660 - Don't check for CVS or Subversion in the sanitycheck
Don't check for CVS or Subversion in the sanitycheck
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2016-12-05 20:28 UTC by Daniel Boles
Modified: 2016-12-05 21:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
sanitycheck: Don't check for CVS or Subversion (1.31 KB, patch)
2016-12-05 20:32 UTC, Daniel Boles
committed Details | Review

Description Daniel Boles 2016-12-05 20:28:08 UTC
dboles	"cvs not found" ... really, in this year?
mcatanzaro	dboles: We should probably make sanitycheck not check for that I guess :)
mcatanzaro	There is no way it is used for anything
mcatanzaro	It still checks for svn too
[...]
dboles	mcatanzaro: want a patch to remove those?
mcatanzaro	dboles: Please!
Comment 1 Daniel Boles 2016-12-05 20:32:54 UTC
Created attachment 341428 [details] [review]
sanitycheck: Don't check for CVS or Subversion

Et voilà.

I also took this opportunity to add an equally pointless header comment for curl/wget, just to match all the others!

Bonus: It'd be nice to have a newer option in the BZ Version box. :)
Comment 2 Michael Catanzaro 2016-12-05 21:00:48 UTC
Review of attachment 341428 [details] [review]:

Thanks
Comment 3 Daniel Boles 2016-12-05 21:08:07 UTC
Pushed to master, thanks!