After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775656 - Delete key mapping stops working
Delete key mapping stops working
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
3.22.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
: 772169 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-12-05 18:44 UTC by Milan Crha
Modified: 2017-02-17 00:19 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Milan Crha 2016-12-05 18:44:57 UTC
As had been risen on the evolution-list:
https://mail.gnome.org/archives/evolution-list/2016-December/msg00004.html

When I start evolution I can happily use the delete key to delete a highlighted message. After a few hours that stops working and I have to click the delete icon in evolution.
Comment 1 Milan Crha 2016-12-05 19:15:03 UTC
The problem was that the so called "NeedInput" flag wasn't cleared once set and it was also treated for all the EWebView-s together, not for each EWebView separately (one window can show a meeting invitation, another can show a regular mail). I also made a change in the mail_reader_key_press_event_cb() to test whether the mail display has a focus, the same as it had been done in mail_shell_view_key_press_event_cb().

Created commit eacfb00 in evo master (3.23.3+)
Created commit 956b2f3 in evo gnome-3-22 (3.22.3+)
Comment 2 Milan Crha 2016-12-12 17:06:46 UTC
*** Bug 772169 has been marked as a duplicate of this bug. ***
Comment 3 John Mellor 2016-12-16 00:10:43 UTC
Not fixed in 3.22.3 on Fedora 25
Comment 4 Milan Crha 2016-12-16 10:04:21 UTC
(In reply to John Mellor from comment #3)
> Not fixed in 3.22.3 on Fedora 25

Any steps, please? The important part is what message is selected (its content), and which part of the UI is selected. Is it the message list, the message itself, a new window with the mesage (like when you double-click the message in the message list).
Comment 5 John Mellor 2016-12-17 01:31:45 UTC
Steps to show not-fixed:
1. click on a message with html content
2. click on the blocking "Load Remote Content" message.
3. In the message box, scroll through the message.
4. Attempt to delete message by pressing the delete key.  Observe failure.
5. Select another message and repeat step 2.
6. Do not scroll the message and just hit delete.  Observe success.

So it would seem that scrolling the message changes the focus or something and the delete key is no longer usable.
Comment 6 Milan Crha 2016-12-19 09:58:27 UTC
*** Bug 776074 has been marked as a duplicate of this bug. ***
Comment 7 Milan Crha 2016-12-19 15:24:18 UTC
I see. When that alert panel is focused, it "steals" the key press and the mail reader, neither the message list, knows about it. It's a different issue than the one fixed with the changes from the comment #1, but with the same result.

The current requirements to have the Delete key working (and quite few other as well) are:
a) either the message list or the message preview is focused
b) when the message preview is focused it cannot have focused any input
   element, which are buttons, text areas, checkboxes and so on, simply anything
   what would use the key itself, even it's not known what exact key it is.

For example when you focused the folder tree on the left, then the delete key also does nothing. I believe it's expected there.
Comment 8 Nate Graham 2016-12-19 16:09:35 UTC
Can this be un-marked as resolved? Seems not fully fixed yet, based on comments in https://bugzilla.gnome.org/show_bug.cgi?id=776074
Comment 9 Milan Crha 2016-12-19 17:04:16 UTC
(In reply to Nate Graham from comment #8)
> Can this be un-marked as resolved? Seems not fully fixed yet, based on
> comments in https://bugzilla.gnome.org/show_bug.cgi?id=776074

Right, thinking of it in the light of comment #7 (and the all investigation I did before making such statement), I believe I was wrong and these two bug reports are not about the same issue. I'm reopening your bug instead. I'm sorry for the confusion.
Comment 10 Nate Graham 2016-12-19 17:08:57 UTC
Cool, thanks!
Comment 11 John Mellor 2017-01-14 16:55:40 UTC
Can we please re-open this issue?  Comments 5 and 7 show that is is not fully fixed.  Can we also raise the priority to something critical, since it has a large usability impact?
Comment 12 Guy Rouillier 2017-01-15 04:58:55 UTC
New Evolution user here, and I encountered this issue within 1/2 hour of installation.  Specifically, regarding comment #7, I discovered that while looking at an HTML message in preview, if I click the button that says "Load remote content", then the Delete key no longer works.  I have to either click in the message body, or click the header in the header list, for the Delete key to work again.

This is a fairly critical issue that will annoy many inexperienced users.  I also discovered the problem that Milan mentions of clicking a folder in the folder list, which selects a header in the header list does not actually give that header focus; so again, the Delete key does not work.  I can see where the solution to this might be debatable.  But in other cases, the solution of returning focus to the message window seems obvious and non-controversial.  This solution would also allow the Delete key to function a most people expect.

Thanks.
Comment 13 Milan Crha 2017-01-18 15:03:35 UTC
Thanks for the update. Rather than reopening, I'd prefer to get a set of exact scenarios where these keys stop working (it's more than the delete key, though this one is probably the most visible) and fix them one by one. Fox example I do not think anyone would like to see a message deleted when the folder tree is focused.

Just like Guy described in comment #12. I fixed it with the below changes. The problem there was that after the notification had been closed nothing had focus there, thus nothing could be notified about the event (or the one structure which listens for this). I changed it to set focus to the message preview content when there is nothing focused after the notification part being hidden.

Created commit ac268fc in evo master (3.23.90+)
Created commit f44e1f8 in evo gnome-3-22 (3.22.5+)
Comment 14 Guy Rouillier 2017-01-19 05:30:51 UTC
Thank you, Milan.  I agree that the message window losing focus is the scenario that most people will encounter while navigating through the message list with the delete key.  So that change you've made will have a significant positive affect on the user experience, especially for novice users such as myself.
Comment 15 John Mellor 2017-02-17 00:19:18 UTC
Thank you Milan,
Over the last 24hrs, Fedora rolled out the 3.22.5 version, and I can confirm that the delete key behaviour works beautifully again.