GNOME Bugzilla – Bug 775616
Fail to build with freerdp 20161124git2a6dbab because CLRBUF_32BPP is removed
Last modified: 2021-05-26 09:24:49 UTC
We are going to update FreeRDP package in FreeBSD to 20161124 (commit 2a6dbab): https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212004 https://reviews.freebsd.org/D8712 However, CLRBUF_32BPP used by vinagre is removed by commit df35c13, so the latest vinagre doesn't build with it. https://github.com/FreeRDP/FreeRDP/commit/df35c135d19152c5a00f71d5f7dc5ea3aaf2d3dc I will upload a simple patch that seems to fix the problem.
Created attachment 341384 [details] [review] Fix build with recent FreeRDP git snapshot FreeRDP commit df35c13 removes CLRBUF_32BPP macro and changes the way to call gdi_init function. As FreeRDP doesn't bump its version number after this API break, we can only use CLRBUF_32BPP macro itself to check for the availablility of new API.
Created attachment 341385 [details] [review] List of callback functions that cause incompatible pointer type warnings during compilation
Comment on attachment 341385 [details] [review] List of callback functions that cause incompatible pointer type warnings during compilation This is not a proposed patch. It is a minimal patch that can be used to silence the warning. I am not sure how to properly fix it because FreeRDP usually changes API without bumping version or providing an easy way to detect it. We probably need a lot of new checks in configure to keep it working with new and old versions of FreeRDP.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version of Vinagre, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new enhancement request ticket at https://gitlab.gnome.org/GNOME/vinagre/-/issues/ Thank you for your understanding and your help.