After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775612 - No thumbnail shown for new overview item after previous item is removed from overview
No thumbnail shown for new overview item after previous item is removed from ...
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Overview
3.22.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-12-05 03:06 UTC by Michael Catanzaro
Modified: 2016-12-06 15:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Move some duplicate code into ephy_history_query_new_for_overview (4.05 KB, patch)
2016-12-05 03:08 UTC, Michael Catanzaro
committed Details | Review
Refactor delayed overview thumbnail update handling (6.71 KB, patch)
2016-12-05 03:08 UTC, Michael Catanzaro
committed Details | Review
embed-shell: Schedule thumbnail updates after updating overview (1.15 KB, patch)
2016-12-05 03:08 UTC, Michael Catanzaro
committed Details | Review

Description Michael Catanzaro 2016-12-05 03:06:57 UTC
No thumbnail is shown for the new overview item after previous item is removed from overview.

Follow-up to bugs #775604 and #772350.
Comment 1 Michael Catanzaro 2016-12-05 03:08:07 UTC
CC Carlos because my patches move some overview code from EphyAboutHandler to EphyEmbedShell, and it feels like the wrong direction. Want to review them?
Comment 2 Michael Catanzaro 2016-12-05 03:08:40 UTC
Created attachment 341374 [details] [review]
Move some duplicate code into ephy_history_query_new_for_overview
Comment 3 Michael Catanzaro 2016-12-05 03:08:43 UTC
Created attachment 341375 [details] [review]
Refactor delayed overview thumbnail update handling

Move this logic to EphyEmbedShell. It will be needed there in the next
commit and I don't want to duplicate the code in two different places.
Comment 4 Michael Catanzaro 2016-12-05 03:08:47 UTC
Created attachment 341376 [details] [review]
embed-shell: Schedule thumbnail updates after updating overview

Otherwise we do not display a thumbnail for new overview items when a
previous overview item is removed, even if we have a snapshot in the
snapshot database. This doesn't and cannot fix the case where no
snapshot exists -- sometimes we just really don't have a usable snapshot
-- but usually we do have a snapshot and this fixes the general case.
Comment 5 Michael Catanzaro 2016-12-05 03:11:30 UTC
Review of attachment 341374 [details] [review]:

::: embed/ephy-about-handler.h
@@ +38,3 @@
                                                      WebKitURISchemeRequest *request);
+
+EphyHistoryQuery *ephy_history_query_new_for_overview (void);

It feels like an awkward location as it's not an EphyAboutHandler method, but I'm not keen on creating a new file for it....
Comment 6 Michael Catanzaro 2016-12-06 15:14:17 UTC
Attachment 341374 [details] pushed as 02fdbf1 - Move some duplicate code into ephy_history_query_new_for_overview
Attachment 341375 [details] pushed as 1932254 - Refactor delayed overview thumbnail update handling
Attachment 341376 [details] pushed as 9ec1848 - embed-shell: Schedule thumbnail updates after updating overview