GNOME Bugzilla – Bug 775612
No thumbnail shown for new overview item after previous item is removed from overview
Last modified: 2016-12-06 15:14:24 UTC
No thumbnail is shown for the new overview item after previous item is removed from overview. Follow-up to bugs #775604 and #772350.
CC Carlos because my patches move some overview code from EphyAboutHandler to EphyEmbedShell, and it feels like the wrong direction. Want to review them?
Created attachment 341374 [details] [review] Move some duplicate code into ephy_history_query_new_for_overview
Created attachment 341375 [details] [review] Refactor delayed overview thumbnail update handling Move this logic to EphyEmbedShell. It will be needed there in the next commit and I don't want to duplicate the code in two different places.
Created attachment 341376 [details] [review] embed-shell: Schedule thumbnail updates after updating overview Otherwise we do not display a thumbnail for new overview items when a previous overview item is removed, even if we have a snapshot in the snapshot database. This doesn't and cannot fix the case where no snapshot exists -- sometimes we just really don't have a usable snapshot -- but usually we do have a snapshot and this fixes the general case.
Review of attachment 341374 [details] [review]: ::: embed/ephy-about-handler.h @@ +38,3 @@ WebKitURISchemeRequest *request); + +EphyHistoryQuery *ephy_history_query_new_for_overview (void); It feels like an awkward location as it's not an EphyAboutHandler method, but I'm not keen on creating a new file for it....
Attachment 341374 [details] pushed as 02fdbf1 - Move some duplicate code into ephy_history_query_new_for_overview Attachment 341375 [details] pushed as 1932254 - Refactor delayed overview thumbnail update handling Attachment 341376 [details] pushed as 9ec1848 - embed-shell: Schedule thumbnail updates after updating overview