GNOME Bugzilla – Bug 775603
Cannot open uncompressed info pages
Last modified: 2017-06-20 08:30:35 UTC
When I tried to open an uncompressed info page with command such as 'yelp info:libffi', yelp shows a blank page and runs with high CPU usage. It seems that this problem is caused by function yelp_magic_decompressor_convert in file libyelp/yelp-magic-decompressor.c, which never returns G_CONVERTER_FINISHED when input data are uncompressed. This causes yelp to wait indefinitely in function open_info_file in file libyelp/yelp-info-parser.c because the g_input_stream_read call never returns.
Created attachment 341359 [details] [review]
magic-decompressor: Fix handling of uncompressed info pages
When an uncompressed info page is specified, function
yelp_magic_decompressor_convert always returns G_CONVERTER_CONVERTED.
This causes file loading to never be completed because function
g_input_stream_read keeps waiting for new data until the converter
This problem is very likely to happen on FreeBSD because most packages install uncompressed info pages.
It is still not possible to open man pages with yelp on FreeBSD because bug 648854 is not resolved.
Ping ... The patch has stayed here for 6 months without being reviewed.
Review of attachment 341359 [details] [review]:
Thanks for the patch - I pushed it to master as commit 7d603db8dd0eeceae618cd580156fe7f550bc5ff.