After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775562 - Don't use PhotosViewModel in PhotosMainToolbar
Don't use PhotosViewModel in PhotosMainToolbar
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
3.23.x
Other All
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks: 690623
 
 
Reported: 2016-12-03 09:45 UTC by Debarshi Ray
Modified: 2016-12-06 11:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
embed, main-toolbar: Don't use ViewModel to enable/disable the buttons (9.30 KB, patch)
2016-12-03 09:54 UTC, Debarshi Ray 		committed Details | Review
main-toolbar: Avoid CRITICALs when activating an item (1.69 KB, patch)
2016-12-06 11:30 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2016-12-03 09:45:17 UTC 
We are using the PhotosViewModel that is currently being displayed in PhotosMainToolbar to enable/disable the search and selection buttons. We should stop doing that to reduce our ViewModel dependency because we want to remove it during the GtkFlowBox port (bug 690623).

Nowadays, each mode has its separate PhotosBaseManager (bug 770157) and they implement the GListModel interface (bug 774191). So it will be easy to find an alternative.
Comment 1 Debarshi Ray 2016-12-03 09:54:48 UTC 
Created attachment 341303 [details] [review]
embed, main-toolbar: Don't use ViewModel to enable/disable the buttons
Comment 2 Debarshi Ray 2016-12-05 13:00:08 UTC 
Comment on attachment 341303 [details] [review]
embed, main-toolbar: Don't use ViewModel to enable/disable the buttons

Pushed to master. Let me know if something is wrong.
Comment 3 Debarshi Ray 2016-12-06 11:30:24 UTC 
Created attachment 341461 [details] [review]
main-toolbar: Avoid CRITICALs when activating an item