GNOME Bugzilla – Bug 775475
Mount Point column displayed for encrypted file systems even when empty
Last modified: 2017-02-14 18:33:20 UTC
The Mount Point column is meant to only be shown in the UI when a file system is mounted or there is an mount point found in /etc/fstab. However the column is always shown, even if empty, for an open LUKS mapping. Fix to follow shortly.
Created attachment 341156 [details] [review] Stop displaying empty Mount Point column for encrypted partitions (v1) Hi Curtis, I decided to fix this minor issue as a separate bug rather than bundle with the ongoing work for Bug 774818 - Implement LUKS read-write actions NOT requiring a passphrase. Here's the patch to fix this and a couple of small tidy-ups. Thanks, Mike
Hi Mike, The patch set in comment #1 looks good to me. In my testing it worked as expected and only displayed the mount column when the encrypted partition was both open and mounted. I found only one very minor spelling mistake in the commit message of P2 - Reorder and rename params to TreeView_Detail::load_partitions() Change from: Reorder the parameters into the same order in which the occur in the ^^^ to: Reorder the parameters into the same order in which they occur in the If there are no other concerns then I will commit this patch set (with minor spelling correction) to the git repository tomorrow. Curtis
Thank you Mike for this enhancement. The patch set in comment #1 has been committed to the git repository for inclusion in the next release of GParted. The relevant git commits can be viewed at the following links: Fix detection of empty mount point column for encrypted file systems (#775475) https://git.gnome.org/browse/gparted/commit/?id=9e932ec7d0c2e6e56f1d0dd3495158fb492289b8 Reorder and rename params to TreeView_Detail::load_partitions() https://git.gnome.org/browse/gparted/commit/?id=43f2a4bd0876debf82d2223ba065379117505797 Add translatable files reminder to HACKING file https://git.gnome.org/browse/gparted/commit/?id=77978ee7c12d8b3a4d783c43e4144da203f4592a
This enhancement was included in the GParted 0.28.0 release on February 14, 2017.