After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775411 - x264enc: Correctly pass interlacing/TFF information
x264enc: Correctly pass interlacing/TFF information
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other Linux
: Normal enhancement
: 1.11.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-11-30 15:32 UTC by Vivia Nikolaidou
Modified: 2017-04-09 09:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-x264enc-Correctly-pass-interlacing-TFF-information.patch (1.63 KB, patch)
2016-11-30 15:32 UTC, Vivia Nikolaidou
committed Details | Review
0002-x264enc-Add-information-for-mixed-mode.patch (1.92 KB, patch)
2016-11-30 16:12 UTC, Vivia Nikolaidou
committed Details | Review

Description Vivia Nikolaidou 2016-11-30 15:32:01 UTC
Give the interlacing information correctly to the encoder. Also parse
TFF/BFF information from the caps and pass it too.
Comment 1 Vivia Nikolaidou 2016-11-30 15:32:30 UTC
Created attachment 341063 [details] [review]
0001-x264enc-Correctly-pass-interlacing-TFF-information.patch
Comment 2 Vivia Nikolaidou 2016-11-30 16:12:20 UTC
Created attachment 341068 [details] [review]
0002-x264enc-Add-information-for-mixed-mode.patch
Comment 3 Sebastian Dröge (slomo) 2016-11-30 16:54:40 UTC
commit c40b40b36f460bd30d60e8df65436b89875326b1
Author: Vivia Nikolaidou <vivia@ahiru.eu>
Date:   Wed Nov 30 18:11:30 2016 +0200

    x264enc: Add information for mixed mode
    
    https://bugzilla.gnome.org/show_bug.cgi?id=775411

commit dae49907e274e2bd37d7e86aa7110cef8dea8372
Author: Vivia Nikolaidou <vivia@ahiru.eu>
Date:   Wed Nov 30 17:30:33 2016 +0200

    x264enc: Correctly pass interlacing/TFF information
    
    Give the interlacing information correctly to the encoder. Also parse
    TFF/BFF information from the caps and pass it too.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=775411
Comment 4 Tim-Philipp Müller 2017-04-08 12:19:47 UTC
This now renders the "interlaced" property non-functional, is that right?
Comment 5 Sebastian Dröge (slomo) 2017-04-09 07:40:07 UTC
Indeed, that property is not used anymore then. We should probably change that somehow.

What would you suggest for taking the property and the caps into account? Remember if the property was changed and then use that instead of the caps?
Comment 6 Tim-Philipp Müller 2017-04-09 09:39:59 UTC
I don't really mind that the property isn't used any more, but we should at least deprecate it then and add a note in the description that it's not functional.

Or make it functional again, one of those :)

I'd only look at the property if caps say progressive and property set to interlaced=true, if we want to make it work at all.

I'd rather deprecate it though.