GNOME Bugzilla – Bug 775411
x264enc: Correctly pass interlacing/TFF information
Last modified: 2017-04-09 09:39:59 UTC
Give the interlacing information correctly to the encoder. Also parse TFF/BFF information from the caps and pass it too.
Created attachment 341063 [details] [review] 0001-x264enc-Correctly-pass-interlacing-TFF-information.patch
Created attachment 341068 [details] [review] 0002-x264enc-Add-information-for-mixed-mode.patch
commit c40b40b36f460bd30d60e8df65436b89875326b1 Author: Vivia Nikolaidou <vivia@ahiru.eu> Date: Wed Nov 30 18:11:30 2016 +0200 x264enc: Add information for mixed mode https://bugzilla.gnome.org/show_bug.cgi?id=775411 commit dae49907e274e2bd37d7e86aa7110cef8dea8372 Author: Vivia Nikolaidou <vivia@ahiru.eu> Date: Wed Nov 30 17:30:33 2016 +0200 x264enc: Correctly pass interlacing/TFF information Give the interlacing information correctly to the encoder. Also parse TFF/BFF information from the caps and pass it too. https://bugzilla.gnome.org/show_bug.cgi?id=775411
This now renders the "interlaced" property non-functional, is that right?
Indeed, that property is not used anymore then. We should probably change that somehow. What would you suggest for taking the property and the caps into account? Remember if the property was changed and then use that instead of the caps?
I don't really mind that the property isn't used any more, but we should at least deprecate it then and add a note in the description that it's not functional. Or make it functional again, one of those :) I'd only look at the property if caps say progressive and property set to interlaced=true, if we want to make it work at all. I'd rather deprecate it though.