After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775396 - Delete Layer/Channel/Path should be consistently the last option in respective dialogs
Delete Layer/Channel/Path should be consistently the last option in respectiv...
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: User Interface
git master
Other All
: Normal normal
: 2.10
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2016-11-30 13:00 UTC by Vladimir Savic
Modified: 2016-12-07 13:26 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Vladimir Savic 2016-11-30 13:00:33 UTC
As in summary. It would be much better for users to know immediately where to look for that "destructive" operation.
Comment 1 Jehan 2016-11-30 13:24:18 UTC
It's true that the "common buttons" (all of them, not only delete) could have a more consistent position across docks. That is: New item, duplicate item (I wonder if these 2 should not be next to each other by the way), the 2 stack reorder arrows and finally delete item.
Comment 2 Jehan 2016-12-04 18:36:14 UTC
Someone made me the same remark yesterday. I fixed the "Delete" action order. I think this along with the "New" buttons are definitely to be the rightest and leftest respectively, indeed.
Not sure yet for the duplicate, raise and lower.

commit f296988665a5b46e83c641ccf68c8ba300e3d0f0
Author: Jehan <jehan@girinstud.io>
Date:   Sun Dec 4 19:25:00 2016 +0100

    Bug 775396 - Delete Layer/Channel/Path should be consistently the last...
    
    option in respective dialogs.

 app/widgets/gimpchanneltreeview.c | 2 +-
 app/widgets/gimplayertreeview.c   | 2 +-
 app/widgets/gimpvectorstreeview.c | 6 +++---
 3 files changed, 5 insertions(+), 5 deletions(-)
Comment 3 Michael Schumacher 2016-12-07 08:45:40 UTC
Delete seems to be the rightmost button in 2.8 - was this changed in the development branch?
Comment 4 Jehan 2016-12-07 13:26:02 UTC
> Delete seems to be the rightmost button in 2.8 - was this changed in the development branch?

Yes I also tested 2.8 before deciding and seeing that delete was already the last button on all 3 docks reinforced the idea that's the right thing to do.

For the layer dock at least, the reason is that a new button has been added ("Add a mask") and I just don't think any deep thought was put to "where should it be added?" so it just went to the end.