After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775324 - Add a button to enabled/diseabled tap-and-drag
Add a button to enabled/diseabled tap-and-drag
Status: RESOLVED OBSOLETE
Product: gnome-control-center
Classification: Core
Component: Mouse
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
triaged
Depends on: 775755 775756
Blocks:
 
 
Reported: 2016-11-29 14:06 UTC by freeroot
Modified: 2021-06-09 16:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Suggestion of code (5.92 KB, patch)
2016-12-07 13:23 UTC, freeroot
none Details | Review
Suggesion of code 2 (5.43 KB, patch)
2018-03-31 22:46 UTC, freeroot
none Details | Review

Description freeroot 2016-11-29 14:06:03 UTC
Hello,

I'm using Fedora 25 in a macintel (macbook 6,1 of 2010) and I would like to have the possibility to not use "tap-and-drap" while I'm using "tap-to-click". libinput with/in Wayland in fedora 25 doesn't let the possibility to modify gnome's options whereas the distinction of the two options is permitted by libinput. So, my researches make me come here to report my problem.

Thx for answers.
Comment 1 freeroot 2016-12-07 13:23:50 UTC
Created attachment 341548 [details] [review]
Suggestion of code
Comment 2 freeroot 2016-12-07 13:35:11 UTC
tap-and-drag is already in specification of libinput but not in mutter, gnome-control-center nor gsettings-desktop-deamons. So, 3 commits are necessary to let the possibility to people to choose tap-and-drag or not. That's why I opened 3 bugs for 3 modules of gnome :

mutter: https://bugzilla.gnome.org/show_bug.cgi?id=775755
gsettings-desktop-deamons: https://bugzilla.gnome.org/show_bug.cgi?id=775756
gnome-control-center: https://bugzilla.gnome.org/show_bug.cgi?id=775324
Comment 3 Bastien Nocera 2016-12-09 13:24:28 UTC
As per bug 775756, I don't think it needs to be a configuration option (yet).

FWIW, the equivalent setting in macOS is in the universal access panel. Maybe it should be there as well in GNOME.
Comment 4 freeroot 2016-12-09 14:19:31 UTC
Why not. I thought mouse panel were a centralized panel for all configuration options about mouse but if there is a universal access panel for GNOME and you think that mac dev have good reason and argumentation, why not.
Comment 5 Theodoros Orfanidis 2017-01-17 01:05:15 UTC
Indeed on MacOS it's called "Enable dragging" and it's in the Accessibility Panel. As far as I know, it's disabled by default (not 100% sure, I know I have never had it enabled). For me, it's the reason I reverted back to X11, since I can't stand the accidental drags when tapping. It is a supported option by libinput and I can disable it on X by adding Option "TappingDrag" "off" in a .conf file.

I'd love to have that option added to Gnome Settings! As a matter of fact, I was looking around to implementing it myself, but thankfully I found this group of bugs with patches. Let me know if I can help in any way. 
Save Changes
Status:	
NEW
Comment 6 Theodoros Orfanidis 2017-01-17 01:11:11 UTC
Sorry for the extra comment, but the last 3 lines of my previous comment show exactly why I hate this, unchangable and enabled by default, behaviour. :(
Comment 7 Bastien Nocera 2017-01-17 09:39:21 UTC
It was never configurable, and it's still changeable in Xorg if this is really a problem for you. Claiming it's "hardcoded" means that it somebody took the decision to hardcode it. Nobody did, because nobody ever requested the option.
Comment 8 jeremy9856 2017-08-20 07:22:24 UTC
Now that everything is in place (bug 775755, bug 775756), I really thing the patch freeroot kindly made (thanks !) should be implemented if it's validated. The more logical thing to do is to implement the feature in the mouse panel alongside, for instance, Tap to click.
Comment 9 freeroot 2017-11-29 13:23:53 UTC
I hope my patch is still available.

Can someone validate or invalidate or have an opinion about this patch ?
Comment 10 jeremy9856 2018-01-06 19:42:56 UTC
Can this be implemented please ? There no reason that prevent to do it.
Thank you.
Comment 11 Georges Basile Stavracas Neto 2018-01-26 22:41:25 UTC
Review of attachment 341548 [details] [review]:

A quick search tells me that having this option in the Accessibility panel would be a bad idea (hint hint: https://discussions.apple.com/thread/7260715)

One comment about the patch itself.

When testing this patch, toggling the switch made no difference at all. Here's my testing steps:

 * Disabled the switch
 * Went to Nautilus and tapped on a file
 * Tried to move the mouse pointer → entered the dragging mode

I expected to not be able to drag the file by following those steps. Is the patch actually working?

About the commit message, please follow GNOME Control Center's git messages pattern. The message is extremely long, and the title differs from the rest of the repository.

::: panels/mouse/gnome-mouse-properties.ui
@@ +629,3 @@
+                                <property name="margin_end">6</property>
+                                <property name="margin_top">6</property>
+                                <property name="margin_bottom">6</property>

These values are a bit off. They should be: top, bottom → 12, start, end → 20
Comment 12 jeremy9856 2018-01-26 22:50:48 UTC
Can this be the cause of the non working state ?

https://bugzilla.gnome.org/show_bug.cgi?id=775755#c17
Comment 13 Georges Basile Stavracas Neto 2018-01-27 00:13:16 UTC
(In reply to jeremy9856 from comment #12)
> Can this be the cause of the non working state ?
> 
> https://bugzilla.gnome.org/show_bug.cgi?id=775755#c17

Ah, indeed.
Comment 14 freeroot 2018-03-31 22:46:37 UTC
Created attachment 370400 [details] [review]
Suggesion of code 2

Following advices of Georges Basile Stavracas Neto, I've made corrections.

Error in https://bugzilla.gnome.org/show_bug.cgi?id=775755#c17 has been already fixed.
Comment 15 Georges Basile Stavracas Neto 2018-04-12 16:51:37 UTC
Hey, thanks for working on this patch. It almost have gone unoticed! The development of GNOME Control Center moved to GitLab (gitlab.gnome.org/GNOME/gnome-control-center), could you please open a Merge Request there? I'll highly appreciate!
Comment 16 freeroot 2018-05-09 10:57:05 UTC
Hi, I've opened a merge request in gitlab here : https://gitlab.gnome.org/GNOME/gnome-control-center/merge_requests/36
Comment 17 André Klapper 2021-06-09 16:25:23 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new bug report at
  https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/

Thank you for your understanding and your help.