After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775295 - examples: remove #include <ges-internal.h> from assets.c
examples: remove #include <ges-internal.h> from assets.c
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-editing-services
git master
Other Windows
: Normal normal
: 1.11.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-11-29 01:12 UTC by Scott D Phillips
Modified: 2016-11-29 11:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH gst-editing-services] examples: remove #include <ges-internal.h> from assets.c (1.11 KB, patch)
2016-11-29 01:13 UTC, Scott D Phillips 		committed Details | Review

Description Scott D Phillips 2016-11-29 01:12:27 UTC 
It is not needed and pulling it in is causing a link problem with msvc.
Including ges-internal.h sets the default debug category in assets.c to
_ges_debug. Because _ges_debug is marked as DATA in the libges.def, it
will only be linked from libges.dll if it is marked in the source with
dllimport. Instead of messing with that we can just remove this include.
Comment 1 Scott D Phillips 2016-11-29 01:13:07 UTC 
Created attachment 340956 [details] [review]
[PATCH gst-editing-services] examples: remove #include <ges-internal.h> from assets.c
Comment 2 Sebastian Dröge (slomo) 2016-11-29 11:20:13 UTC 
commit b4b57ddcf8656a2b8015e542ba4c95031bd6bd86
Author: Scott D Phillips <scott.d.phillips@intel.com>
Date:   Mon Nov 28 17:07:39 2016 -0800

    examples: remove #include <ges-internal.h> from assets.c
    
    It is not needed and pulling it in is causing a link problem with msvc.
    Including ges-internal.h sets the default debug category in assets.c to
    _ges_debug. Because _ges_debug is marked as DATA in the libges.def, it
    will only be linked from libges.dll if it is marked in the source with
    dllimport. Instead of messing with that we can just remove this include.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=775295