After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775282 - window-list: duplicate style definition in classic.css, button has wrong style
window-list: duplicate style definition in classic.css, button has wrong style
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: extensions
3.22.x
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2016-11-28 20:48 UTC by rudolf
Modified: 2017-01-20 13:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot with negative margin (10.85 KB, image/png)
2016-12-07 15:28 UTC, Hyungwon Hwang 		  Details
screenshot with positive margin (25.12 KB, image/png)
2016-12-07 15:29 UTC, Hyungwon Hwang 		  Details
window-list: remove the wrong style for minimized window (898 bytes, patch)
2016-12-07 15:50 UTC, Hyungwon Hwang 		none Details | Review
theme: window-list minimized button (852 bytes, patch)
2017-01-20 13:46 UTC, Jakub Steiner 		committed Details | Review

Description rudolf 2016-11-28 20:48:06 UTC 
Style of minimized window button is defined twice in classic.css and second style definition is wrong. IMO minimized window should have negative inset, not positive. It currently looks very weird. Removing last 3 lines fixes the problem.


tail -n 8 classic.css:

.bottom-panel .window-button.minimized > StWidget {
  color: #888;
  box-shadow: inset -1px -1px 1px rgba(0,0,0,0.5);
}

.bottom-panel .window-button.minimized > StWidget {
  box-shadow: inset 1px 1px 1px rgba(0,0,0,0.5);
}
Comment 1 Hyungwon Hwang 2016-12-07 15:28:56 UTC 
Created attachment 341560 [details]
screenshot with negative margin
Comment 2 Hyungwon Hwang 2016-12-07 15:29:10 UTC 
Created attachment 341561 [details]
screenshot with positive margin
Comment 3 Hyungwon Hwang 2016-12-07 15:49:30 UTC 
It's duplicated. One of them should be removed.

With positive margin, the panel seems in clicked state as it is active. But with negative margin, it does not seem as it is inactive.
Comment 4 Hyungwon Hwang 2016-12-07 15:50:00 UTC 
Created attachment 341562 [details] [review]
window-list: remove the wrong style for minimized window
Comment 5 Florian Müllner 2016-12-07 16:02:06 UTC 
I'll leave it to Jakub to pick which of the two definitions should be removed.
Comment 6 Jakub Steiner 2017-01-20 13:46:40 UTC 
Created attachment 343902 [details] [review]
theme: window-list minimized button

- when a window is minimized, it's unfocused, thus the button
in the window list should remain raised
Comment 7 Jakub Steiner 2017-01-20 13:47:09 UTC 
Attachment 343902 [details] pushed as 5e545d2 - theme: window-list minimized button