After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775228 - x264enc: Auto-detect interlace mode from caps
x264enc: Auto-detect interlace mode from caps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other Linux
: Normal enhancement
: 1.11.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-11-28 13:16 UTC by Vivia Nikolaidou
Modified: 2016-11-28 13:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-x264enc-Auto-detect-interlace-mode-from-caps.patch (1.47 KB, patch)
2016-11-28 13:17 UTC, Vivia Nikolaidou 		committed Details | Review

Description Vivia Nikolaidou 2016-11-28 13:16:21 UTC 
If the caps are interlaced, interlacing is always enabled on the
encoder. If the interlace-mode field is missing or if it's progressive,
the encoder uses the "interlaced" property.
Comment 1 Vivia Nikolaidou 2016-11-28 13:17:03 UTC 
Created attachment 340901 [details] [review]
0001-x264enc-Auto-detect-interlace-mode-from-caps.patch
Comment 2 Sebastian Dröge (slomo) 2016-11-28 13:23:20 UTC 
commit f7d82312bba13806f32d8de56a3d66575bfb08c7
Author: Vivia Nikolaidou <vivia@ahiru.eu>
Date:   Mon Nov 28 15:14:18 2016 +0200

    x264enc: Auto-detect interlace mode from caps
    
    If the caps are interlaced, interlacing is always enabled on the
    encoder. If the interlace-mode field is missing or if it's progressive,
    the encoder uses the "interlaced" property.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=775228
Comment 3 Sebastian Dröge (slomo) 2016-11-28 13:24:14 UTC 
Review of attachment 340901 [details] [review]:

::: ext/x264/gstx264enc.c
@@ -2711,3 @@
       encoder->interlaced = g_value_get_boolean (value);
-      g_string_append_printf (encoder->option_string, ":interlaced=%d",
-          encoder->interlaced);

I think all these should be moved from set_property() to init_encoder()