After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775182 - procstate: Fill in last_processor member on linux
procstate: Fill in last_processor member on linux
Status: RESOLVED FIXED
Product: libgtop
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: libgtop maintainers
libgtop maintainers
Depends on:
Blocks:
 
 
Reported: 2016-11-27 16:16 UTC by Florian Müllner
Modified: 2016-11-28 10:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
procstate: Fill in last_processor member on linux (1.02 KB, patch)
2016-11-27 16:16 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2016-11-27 16:16:16 UTC 
This has come up during work on https://wiki.gnome.org/Design/Apps/Usage, see patch.
Comment 1 Florian Müllner 2016-11-27 16:16:22 UTC 
Created attachment 340849 [details] [review]
procstate: Fill in last_processor member on linux

The field was added almost 20 years ago, but has only been set on
Solaris so far. It turns out we have a use for it now in the new
"Usage" application, so also fill it in on Linux.
Comment 2 Robert Roth 2016-11-27 18:09:27 UTC 
Attachment 340849 [details] pushed as f99bb61 - procstate: Fill in last_processor member on linux
Comment 3 Robert Roth 2016-11-27 18:14:17 UTC 
Thank you for your contribution. I have checked the patch, pushed it to master, and fixed a minor indentation issue (seems like the file you have added your changes to was using tabs for indentation, while your editor seems to prefer spaces).

PS: I didn't know you are also working on Usage, another developer, FYI pstetka on IRC is also working on it, I hope you are aware of that and you are working together, not duplicating the efforts.
Comment 4 Florian Müllner 2016-11-28 10:47:51 UTC 
Thanks for the swift response!

(In reply to Robert Roth from comment #3)
> PS: I didn't know you are also working on Usage, another developer, FYI
> pstetka on IRC is also working on it, I hope you are aware of that and you
> are working together, not duplicating the efforts.

Oh, I'm not actually working on Usage. I met Petr at a hackfest we were both attending, and I tracked down an issue he was having to the missing implementation in libgtop. So no worries, no duplication involved here :-)