After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775178 - Use GtkRevealer instead of GdNotification
Use GtkRevealer instead of GdNotification
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: User Accounts
git master
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-11-27 15:50 UTC by Felipe Borges
Modified: 2016-11-30 12:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
user-accounts: Use GtkRevealer instead of GdNotification (6.66 KB, patch)
2016-11-27 15:51 UTC, Felipe Borges
committed Details | Review
Screenshot GdNotification (before) x GtkRevealer (after) (86.39 KB, image/png)
2016-11-29 14:47 UTC, Felipe Borges
  Details

Description Felipe Borges 2016-11-27 15:50:54 UTC
.
Comment 1 Felipe Borges 2016-11-27 15:51:20 UTC
Created attachment 340845 [details] [review]
user-accounts: Use GtkRevealer instead of GdNotification

GtkRevealer combined with the "app-notification" class is enough
to represent the notification concept nowadays.
Comment 2 Bastien Nocera 2016-11-28 06:19:13 UTC
Ditto bug 775183, screenshots would be useful.
Comment 3 Felipe Borges 2016-11-29 14:47:46 UTC
Created attachment 340979 [details]
Screenshot GdNotification (before) x GtkRevealer (after)
Comment 4 Bastien Nocera 2016-11-30 11:53:08 UTC
Review of attachment 340845 [details] [review]:

Looks good!
Comment 5 Felipe Borges 2016-11-30 12:07:05 UTC
Thanks!

Attachment 340845 [details] pushed as 120956f - user-accounts: Use GtkRevealer instead of GdNotification