After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775163 - win32/gdkkeys backport of GTK3 changes causes compile issues on windows
win32/gdkkeys backport of GTK3 changes causes compile issues on windows
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Win32
2.24.x
Other Windows
: Normal normal
: ---
Assigned To: gtk-win32 maintainers
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2016-11-27 00:13 UTC by Bug ByteMan
Modified: 2016-11-28 15:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
W32: Ensure that gtkwin32keys.h is not needed by GTK+ users (1.79 KB, patch)
2016-11-27 09:40 UTC, LRN 		committed Details | Review

Description Bug ByteMan 2016-11-27 00:13:45 UTC 
The fix for bug 768722 causes compile issues on windows.

The installed version of gdkwin32.h references the following file which is NOT included in the install location (it only exists in the source tree):

#define __GDKWIN32_H_INSIDE__

#include <gdk/win32/gdkwin32keys.h>

#undef __GDKWIN32_H_INSIDE__
Comment 1 LRN 2016-11-27 07:08:06 UTC 
Does everything work if you manually copy it from the source tree to ${prefix}/include/gtk-2.0/gdk?
Comment 2 LRN 2016-11-27 09:40:15 UTC 
Created attachment 340833 [details] [review]
W32: Ensure that gtkwin32keys.h is not needed by GTK+ users

Does this patch work for you?
Comment 3 Bug ByteMan 2016-11-28 01:53:39 UTC 
The patch worked.  Thanks for the quick response!
Comment 4 LRN 2016-11-28 15:01:41 UTC 
Attachment 340833 [details] pushed as cc2d701 - W32: Ensure that gtkwin32keys.h is not needed by GTK+ users