GNOME Bugzilla – Bug 775153
main-view: Forget the last non-range selection once we unset the selection mode
Last modified: 2016-11-27 14:05:17 UTC
The last_selected_id variable was introduced in the following commit: commit b82e4c3722f4e83b429d9b72a9a20172fe3a7cd9 Author: Alexander Larsson <alexl@redhat.com> Date: Thu Apr 11 11:19:14 2013 +0200 Make multi range selection work right When you range select you want the range to start from the last single selection you made, not from some random selected item. For instance If you first select item 3-5 and then 9-7 you want 7,8,9 selected not (like now) 6,7. We keep the column id of the last item we initially selected (i.e. no range select). If this item disappears or something we fall back on the old code. We can also simplify the selection_mode_select_range code a bit now that selection_mode_do_select_range handles ranges in any order. https://bugzilla.gnome.org/show_bug.cgi?id=697645 As described above, if we select 3, 5 and 9, and then shift+select 7, we want 9, 8, 7 to be selected. But if we unset the selection mode, come back and shift+select 1, we don't want everything to get selected. The selection history should not survive across multiple selection mode sessions.
Created attachment 340809 [details] [review] main-view: Forget the last non-range selection when leaving the mode
Comment on attachment 340809 [details] [review] main-view: Forget the last non-range selection when leaving the mode Pushed after a one-on-one review from Cosimo at the core apps hackfest.